Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change RA/Dec significant figures from 4 to 6 in aperture photometry plugin #1750

Merged
merged 2 commits into from
Oct 19, 2022

Conversation

camipacifici
Copy link
Contributor

@camipacifici camipacifici commented Oct 19, 2022

Description

This addresses the issue of not having enough significant figures in the coordinates in the aperture photometry plugin.

Change log entry

  • Is a change log needed? If yes, is it added to CHANGES.rst? If you want to avoid merge conflicts,
    list the proposed change log here for review and add to CHANGES.rst before merge. If no, maintainer
    should add a no-changelog-entry-needed label.

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

  • Are two approvals required? Branch protection rule does not check for the second approval. If a second approval is not necessary, please apply the trivial label.
  • Do the proposed changes actually accomplish desired goals? Also manually run the affected example notebooks, if necessary.
  • Do the proposed changes follow the STScI Style Guides?
  • Are tests added/updated as required? If so, do they follow the STScI Style Guides?
  • Are docs added/updated as required? If so, do they follow the STScI Style Guides?
  • Did the CI pass? If not, are the failures related?
  • Is a milestone set?
  • After merge, any internal documentations need updating (e.g., JIRA, Innerspace)?

Copy link
Member

@kecnry kecnry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me, thanks! (Just needs a changelog entry and CI to finish running/pass)

Copy link
Contributor

@bmorris3 bmorris3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. I'm curious though if it makes more sense to display centroids in sexigesimal? Six digits is quite a lot of numbers to read.

@camipacifici
Copy link
Contributor Author

Thank you!

I believe we discussed this at some point and degrees are fine. They just needed enough significant figures.

@pllim pllim merged commit 00e2f57 into spacetelescope:main Oct 19, 2022
@pllim
Copy link
Contributor

pllim commented Oct 19, 2022

LGTM. Thanks!

@camipacifici camipacifici deleted the more-sig-figures branch March 27, 2024 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants