Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

subset plugin: fix IndexError #1700

Merged
merged 2 commits into from
Oct 5, 2022
Merged

Conversation

kecnry
Copy link
Member

@kecnry kecnry commented Oct 4, 2022

Description

This pull request fixes the IndexError raised in the subset plugin when modifying a subset (color in plot options, for example) while "Create New" is selected.

Fixes #1693

Change log entry

  • Is a change log needed? If yes, is it added to CHANGES.rst? If you want to avoid merge conflicts,
    list the proposed change log here for review and add to CHANGES.rst before merge. If no, maintainer
    should add a no-changelog-entry-needed label.

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

  • Are two approvals required? Branch protection rule does not check for the second approval. If a second approval is not necessary, please apply the trivial label.
  • Do the proposed changes actually accomplish desired goals? Also manually run the affected example notebooks, if necessary.
  • Do the proposed changes follow the STScI Style Guides?
  • Are tests added/updated as required? If so, do they follow the STScI Style Guides?
  • Are docs added/updated as required? If so, do they follow the STScI Style Guides?
  • Did the CI pass? If not, are the failures related?
  • Is a milestone set?
  • After merge, any internal documentations need updating (e.g., JIRA, Innerspace)?

@kecnry kecnry added bug Something isn't working plugin Label for plugins common to multiple configurations labels Oct 4, 2022
@kecnry kecnry added this to the 2.11 milestone Oct 4, 2022
when the selection is set to "Create New" and a subset is updated, there is no information that needs to be updated in the plugin
@kecnry kecnry force-pushed the subset-index-error branch from 709a4c7 to 1dddd9e Compare October 4, 2022 17:21
@codecov
Copy link

codecov bot commented Oct 4, 2022

Codecov Report

Base: 87.16% // Head: 87.16% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (52ed625) compared to base (d1506cf).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1700   +/-   ##
=======================================
  Coverage   87.16%   87.16%           
=======================================
  Files          95       95           
  Lines        9908     9910    +2     
=======================================
+ Hits         8636     8638    +2     
  Misses       1272     1272           
Impacted Files Coverage Δ
...igs/default/plugins/subset_plugin/subset_plugin.py 97.91% <100.00%> (+0.02%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@kecnry kecnry marked this pull request as ready for review October 4, 2022 18:04
Copy link
Collaborator

@duytnguyendtn duytnguyendtn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested against main and can confirm it fixes on my end. Thanks for the fix, and even better that you encapsulated it in a test!

Copy link
Contributor

@pllim pllim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@pllim pllim merged commit 139d63e into spacetelescope:main Oct 5, 2022
@kecnry kecnry deleted the subset-index-error branch October 5, 2022 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working plugin Label for plugins common to multiple configurations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Cubeviz: IndexError when changing color of subset layer
3 participants