spectral extraction: update with new model types #1695
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kecnry
force-pushed
the
spec-extract-polytrace
branch
2 times, most recently
from
69df308
to
4fae46c
Compare
kecnry
force-pushed
the
spec-extract-polytrace
branch
2 times, most recently
from
e114465
to
b41ee77
Compare
kecnry
commented
Nov 8, 2022
Comment on lines
-84
to
+98
| :hint="trace_type_selected === 'Flat' ? 'Pixel row for flat trace.' : 'Pixel row initial guess for auto trace.'" | ||
| :hint="trace_type_selected === 'Flat' ? 'Pixel row for flat trace.' : 'Pixel row initial guess for fitting the trace.'" |
There was a problem hiding this comment.
@bmorris3 - does this make sense to you given the conversation in #1827 (comment)?
bmorris3
reviewed
Nov 10, 2022
| elif isinstance(trace, tracing.KosmosTrace): | ||
| self.trace_type_selected = 'Auto' | ||
| elif isinstance(trace, tracing.FitTrace): | ||
| self.trace_type_selected = trace.trace_model.__class__.__name__.strip('1D') |
There was a problem hiding this comment.
Today I learned that the str.strip method takes arguments. Thanks for teaching me something! 😃
kecnry
force-pushed
the
spec-extract-polytrace
branch
from
b41ee77
to
0f53528
Compare
kecnry
force-pushed
the
spec-extract-polytrace
branch
from
0f53528
to
6079a9b
Compare
kecnry
force-pushed
the
spec-extract-polytrace
branch
from
6079a9b
to
7d87f1c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request adds support for
model_typefrom theAutoTraceFitTraceimplementation in astropy/specreduce#128.This will require the specreduce PR to be reviewed, merged, released, and pinned here. Currently this draft PR exists to test that PR and imagine how it might look in jdaviz.
Change log entry
CHANGES.rst? If you want to avoid merge conflicts,list the proposed change log here for review and add to
CHANGES.rstbefore merge. If no, maintainershould add a
no-changelog-entry-neededlabel.Checklist for package maintainer(s)
This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.
triviallabel.