Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable Line Lists when there is no data #1691

Merged
merged 1 commit into from
Oct 5, 2022

Conversation

pllim
Copy link
Contributor

@pllim pllim commented Sep 30, 2022

Description

This pull request is to fix #1669

Close #1690

Change log entry

  • Is a change log needed? If yes, is it added to CHANGES.rst? If you want to avoid merge conflicts,
    list the proposed change log here for review and add to CHANGES.rst before merge. If no, maintainer
    should add a no-changelog-entry-needed label.

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

  • Are two approvals required? Branch protection rule does not check for the second approval. If a second approval is not necessary, please apply the trivial label.
  • Do the proposed changes actually accomplish desired goals? Also manually run the affected example notebooks, if necessary.
  • Do the proposed changes follow the STScI Style Guides?
  • Are tests added/updated as required? If so, do they follow the STScI Style Guides?
  • Are docs added/updated as required? If so, do they follow the STScI Style Guides?
  • Did the CI pass? If not, are the failures related?
  • Is a milestone set?
  • After merge, any internal documentations need updating (e.g., JIRA, Innerspace)?

@pllim pllim added the bug Something isn't working label Sep 30, 2022
@pllim pllim added this to the 2.11 milestone Sep 30, 2022
@pllim pllim added the specviz label Sep 30, 2022
@codecov
Copy link

codecov bot commented Sep 30, 2022

Codecov Report

Base: 87.16% // Head: 87.16% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (38ca560) compared to base (970a915).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1691   +/-   ##
=======================================
  Coverage   87.16%   87.16%           
=======================================
  Files          95       95           
  Lines        9907     9913    +6     
=======================================
+ Hits         8635     8641    +6     
  Misses       1272     1272           
Impacted Files Coverage Δ
...z/configs/default/plugins/line_lists/line_lists.py 74.67% <100.00%> (+0.33%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@kecnry kecnry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is fine for now to "fix" the original bug, and then we can pick up #1690 in the future (likely as part of a refactor of the plugin, since I think even fixing the few things I found might uncover more problems).

Copy link
Collaborator

@duytnguyendtn duytnguyendtn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is good enough for now, but for the refactor, I'd advocate for disabling the actual panel itself, rather than overriding the contents with a message: https://vuetifyjs.com/en/components/expansion-panels/#disabled

@pllim pllim merged commit 3df8b3b into spacetelescope:main Oct 5, 2022
@pllim pllim deleted the linelist-no-data-no-activate branch October 5, 2022 19:11
@pllim
Copy link
Contributor Author

pllim commented Oct 5, 2022

Thanks for the reviews!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Specviz: Loading Line Lists without data results in Traceback
3 participants