-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable Line Lists when there is no data #1691
Conversation
Codecov ReportBase: 87.16% // Head: 87.16% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1691 +/- ##
=======================================
Coverage 87.16% 87.16%
=======================================
Files 95 95
Lines 9907 9913 +6
=======================================
+ Hits 8635 8641 +6
Misses 1272 1272
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is fine for now to "fix" the original bug, and then we can pick up #1690 in the future (likely as part of a refactor of the plugin, since I think even fixing the few things I found might uncover more problems).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is good enough for now, but for the refactor, I'd advocate for disabling the actual panel itself, rather than overriding the contents with a message: https://vuetifyjs.com/en/components/expansion-panels/#disabled
Thanks for the reviews! |
Description
This pull request is to fix #1669
Close #1690
Change log entry
CHANGES.rst
? If you want to avoid merge conflicts,list the proposed change log here for review and add to
CHANGES.rst
before merge. If no, maintainershould add a
no-changelog-entry-needed
label.Checklist for package maintainer(s)
This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.
trivial
label.