-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
spectral-extraction: support floats when possible #1652
Conversation
9c8e4ec
to
eaea7c2
Compare
The changes look reasonable but does existing test need to be updated to pass in some floating point values? |
eaea7c2
to
d67b5a4
Compare
Good idea. I updated one of the tests to pass a float. I think the actually functionality of handling floats is the responsibility of specreduce, not jdaviz, but making sure the float traitlet sets without an error is worth having here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks!
d67b5a4
to
22e4f30
Compare
I cannot tell if this is a bug or just the test case needs updating.
|
Holding up on merging this until a new release of specreduce can be pinned here (tests pass locally for me on specreduce main, but not on 1.1.0, so seems like this requires astropy/specreduce#125 in order to avoid a background overlap error when passing floats). |
22e4f30
to
4b21150
Compare
* for all trace positions, widths, separations
e755cfd
to
cdac66c
Compare
Description
This pull request allows floats (instead of enforcing integers) for all trace positions, widths, and separations.
Blocked by
Change log entry
CHANGES.rst
? If you want to avoid merge conflicts,list the proposed change log here for review and add to
CHANGES.rst
before merge.Bugfixes > Specviz2d:
Spectral-extraction plugin: support floats for all input trace positions, separations, and widths.
Checklist for package maintainer(s)
This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.
trivial
label.