spectral extraction defaults: fix case where background exactly on edge

[kecnry]

Description

This pull request fixes the default spectral extraction parameters in specviz2d when the default background separation would otherwise fall directly on the edge of the image and cause the extraction to fail.

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

• Are two approvals required? Branch protection rule does not check for the second approval. If a second approval is not necessary, please apply the trivial label.
• Do the proposed changes actually accomplish desired goals? Also manually run the affected example notebooks, if necessary.
• Do the proposed changes follow the STScI Style Guides?
• Are tests added/updated as required? If so, do they follow the STScI Style Guides?
• Are docs added/updated as required? If so, do they follow the STScI Style Guides?
• Did the CI pass? If not, are the failures related?
• Is a change log needed? If yes, is it added to CHANGES.rst?
• Is a milestone set?
• After merge, any internal documentations need updating (e.g., JIRA, Innerspace)?

[codecov]

Codecov Report

Base: 86.42% // Head: 86.42% // No change to project coverage 👍

Coverage data is based on head (a4c7073) compared to base (8896492).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #1633   +/-   ##
=======================================
  Coverage   86.42%   86.42%           
=======================================
  Files          94       94           
  Lines        9457     9457           
=======================================
  Hits         8173     8173           
  Misses       1284     1284           

Impacted Files	Coverage Δ
...plugins/spectral_extraction/spectral_extraction.py	91.42% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

[pllim]

This is elegant fix, so LGTM. Except when I use this with #1608 , specreduce gives back flux unit in DN incorrectly. How do I overwrite that in the plot label?

[kecnry]

Except when I use this with #1608 , specreduce gives back flux unit in DN incorrectly. How do I overwrite that in the plot label?

I think we should find the source of that and fix it rather than overwriting the plot label. But either way, I don't think that's directly related to the fix here.

[pllim]

If plot label is out of scope, then I will approve once we figure out the change log capitalization.

[pllim]

p.s. A bit of a shame the wavelength info is lost in specreduce. Because if you use the old code that looks up certain header keywords, it actually has the wavelength info embedded.

[kecnry]

p.s. A bit of a shame the wavelength info is lost in specreduce. Because if you use the old code that looks up certain header keywords, it actually has the wavelength info embedded.

We temporarily force plotting in pixel space in specviz2d because of the axes linking issues between wavelength and pixel. Once that is resolved, it is very easy to revert to plotting in wavelength/frequency.

[pllim]

Thanks!