Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MNT: Pin jsonschema maxversion #1573

Merged
merged 1 commit into from
Aug 16, 2022

Conversation

pllim
Copy link
Contributor

@pllim pllim commented Aug 16, 2022

Description

This pull request is to pin maxversion of jsonschema because a new release broke asdf, which in turn broke our CI.

Once this is merged, we need to open a follow-up issue to unpin it when upstream is fixed.

Related: asdf-format/asdf#1171

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

  • Are two approvals required? Branch protection rule does not check for the second approval. If a second approval is not necessary, please apply the trivial label.
  • Do the proposed changes actually accomplish desired goals? Also manually run the affected example notebooks, if necessary.
  • Do the proposed changes follow the STScI Style Guides?
  • Are tests added/updated as required? If so, do they follow the STScI Style Guides?
  • Are docs added/updated as required? If so, do they follow the STScI Style Guides?
  • Did the CI pass? If not, are the failures related?
  • Is a change log needed? If yes, is it added to CHANGES.rst?
  • Is a milestone set?
  • After merge, any internal documentations need updating (e.g., JIRA, Innerspace)?

because a new release broke asdf upstream.
@pllim pllim added Upstream fix required testing trivial Only needs one approval instead of two no-changelog-entry-needed changelog bot directive labels Aug 16, 2022
@pllim pllim added this to the 2.9 milestone Aug 16, 2022
@github-actions github-actions bot removed the testing label Aug 16, 2022
@codecov
Copy link

codecov bot commented Aug 16, 2022

Codecov Report

Merging #1573 (8fd7f83) into main (e4cfca4) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1573      +/-   ##
==========================================
+ Coverage   85.62%   85.64%   +0.02%     
==========================================
  Files          94       94              
  Lines        9209     9216       +7     
==========================================
+ Hits         7885     7893       +8     
+ Misses       1324     1323       -1     
Impacted Files Coverage Δ
...plugins/spectral_extraction/spectral_extraction.py 88.93% <100.00%> (+0.69%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@pllim
Copy link
Contributor Author

pllim commented Aug 16, 2022

LoL not sure why coverage increased but okay...

@pllim pllim marked this pull request as ready for review August 16, 2022 15:24
Copy link
Member

@kecnry kecnry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!!

@kecnry kecnry merged commit 6060929 into spacetelescope:main Aug 16, 2022
@pllim pllim deleted the jsonschema-broke-asdf branch August 16, 2022 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog-entry-needed changelog bot directive Ready for final review trivial Only needs one approval instead of two Upstream fix required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants