Ignore the bounding box ordering warning when reading files #526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WilliamJamieson
force-pushed
the
bugfix/ignore_warnings_from_existing_files
branch
from
976dafd
to
2a1fc83
Compare
|
@pllim can you confirm this prevents the warnings from files you found in your test suites? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #526 +/- ##
==========================================
+ Coverage 87.42% 87.46% +0.03%
==========================================
Files 22 22
Lines 3874 3886 +12
==========================================
+ Hits 3387 3399 +12
Misses 487 487 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
pllim
added a commit
to pllim/jdaviz
that referenced
this pull request
Nov 14, 2024
pllim
added a commit
to pllim/jdaviz
that referenced
this pull request
Nov 14, 2024
pllim
added a commit
to pllim/specutils
that referenced
this pull request
Nov 14, 2024
|
Trying this out here: |
|
Somehow this broke |
pllim
reviewed
Nov 14, 2024
|
|
||
| # Check that no warning is issued for the bounding box of this WCS object | ||
| with warnings.catch_warnings(): | ||
| warnings.simplefilter("error") |
This comment was marked as resolved.
This comment was marked as resolved.
WilliamJamieson
force-pushed
the
bugfix/ignore_warnings_from_existing_files
branch
from
510b4fb
to
3361532
Compare
pllim
approved these changes
Nov 14, 2024
WilliamJamieson
force-pushed
the
bugfix/ignore_warnings_from_existing_files
branch
from
3361532
to
b8e242c
Compare
|
Any reason why this still unmerged? Once this is merged, I can undo the downstream hackeries. Thanks! |
Old files in the MAST archive have ambiguous encodings for the bounding box which triggers this warning spuriously. Thus this warning should be ignored for written files. The warning exists for dynamically created WCS objects such as those created during a unit test, not those arising from file reads.
WilliamJamieson
force-pushed
the
bugfix/ignore_warnings_from_existing_files
branch
from
b8e242c
to
a79d1be
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Old files in the MAST archive have ambiguous encodings for the bounding box which triggers this warning spuriously. Thus this warning should be ignored for written files. The warning exists for dynamically created WCS objects such as those created during a unit test, not those arising from file reads.
This is a compromise that @pllim convinced me would be necessary to avoid user complaints when using GWCS originating form older files they got from MAST.