Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spring cleaning coordinate frames #457

Open
wants to merge 41 commits into
base: master
Choose a base branch
from
Open

Spring cleaning coordinate frames #457

wants to merge 41 commits into from
+1,083 −801

Commits on Nov 20, 2024

  1. Define and document the core CoordinateFrame API 

    This creates a `BaseCoordinateFrame` class, definining the minimal API
for a coordinate frame with descriptive docstrings. This is done mainly
as an exercise to easily review and document the API. Also add
significant docstring to the module describing how and why coordinate
frames work.
    @Cadair @WilliamJamieson
    Cadair authored and WilliamJamieson committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    9148768 View commit details
    Browse the repository at this point in the history

  2. First pass at restructuring the pixel <> world API 

    The goal of this refactoring is to be able to remove `Frame.coordinates`
and `Frame.coordinate_to_quantity` and rely on the Astropy WCSAPI
machinery to do those conversions.
    @Cadair @WilliamJamieson
    Cadair authored and WilliamJamieson committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    060b469 View commit details
    Browse the repository at this point in the history

  3. Remove now unused methods 

    coordinates() and coordinate_to_quantity() are replaced by APE 14 methods
    @Cadair @WilliamJamieson
    Cadair authored and WilliamJamieson committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    0f28cf7 View commit details
    Browse the repository at this point in the history

  4. Rewrite coordinate systems tests for APE 14 

    This highlights some API changes here.
    @Cadair @WilliamJamieson
    Cadair authored and WilliamJamieson committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    f796800 View commit details
    Browse the repository at this point in the history

  5. cleanup

    @Cadair @WilliamJamieson
    Cadair authored and WilliamJamieson committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    a7c7a2e View commit details
    Browse the repository at this point in the history

  6. Revert changes to inverse w/r/t with_units

    @Cadair @WilliamJamieson
    Cadair authored and WilliamJamieson committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    16c2883 View commit details
    Browse the repository at this point in the history

  7. Use is_high_level to detect input to inverse

    @Cadair @WilliamJamieson
    Cadair authored and WilliamJamieson committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    2d8663c View commit details
    Browse the repository at this point in the history

  8. Remove isnumerical

    @Cadair @WilliamJamieson
    Cadair authored and WilliamJamieson committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    9064448 View commit details
    Browse the repository at this point in the history

  9. Remove old test

    @Cadair @WilliamJamieson
    Cadair authored and WilliamJamieson committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    361a602 View commit details
    Browse the repository at this point in the history

  10. Remove unused imports

    @Cadair @WilliamJamieson
    Cadair authored and WilliamJamieson committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    118f2a1 View commit details
    Browse the repository at this point in the history

  11. Fix doc build

    @Cadair @WilliamJamieson
    Cadair authored and WilliamJamieson committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    66182cd View commit details
    Browse the repository at this point in the history

  12. Delete reference_position 

    Closes spacetelescope#436
    @Cadair @WilliamJamieson
    Cadair authored and WilliamJamieson committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    4ebaabc View commit details
    Browse the repository at this point in the history

  13. lint

    @Cadair @WilliamJamieson
    Cadair authored and WilliamJamieson committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    00714d0 View commit details
    Browse the repository at this point in the history

  14. Add a test for axes ordering with CelestialFrame 

    fixes spacetelescope#269
    @Cadair @WilliamJamieson
    Cadair authored and WilliamJamieson committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    9e6af96 View commit details
    Browse the repository at this point in the history

  15. Test different Units said Nadia 💥

    @Cadair @WilliamJamieson
    Cadair authored and WilliamJamieson committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    94b94fd View commit details
    Browse the repository at this point in the history

  16. First attempt at keeping a sorted and unsorted list of frame props

    @Cadair @WilliamJamieson
    Cadair authored and WilliamJamieson committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    524b844 View commit details
    Browse the repository at this point in the history

  17. make tests pass, ecept slicing

    @WilliamJamieson
    Nadia Dencheva authored and WilliamJamieson committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    cc9442f View commit details
    Browse the repository at this point in the history

  18. ensure units are units

    @Cadair @WilliamJamieson
    Cadair authored and WilliamJamieson committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    599db26 View commit details
    Browse the repository at this point in the history

  19. Raise an error if with_units is used in numerical inverse

    @Cadair @WilliamJamieson
    Cadair authored and WilliamJamieson committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    fe91f0f View commit details
    Browse the repository at this point in the history

  20. Refactor Frames to require _native_world_axis_object_components 

    This means that world_axis_object_components can be automatically sorted
for all frames.
    @Cadair @WilliamJamieson
    Cadair authored and WilliamJamieson committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    243eda1 View commit details
    Browse the repository at this point in the history

  21. Apply suggestions from code review

    @Cadair @WilliamJamieson
    Cadair authored and WilliamJamieson committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    17d4b9d View commit details
    Browse the repository at this point in the history

  22. Ensure we call values_to_high correctly

    @Cadair @WilliamJamieson
    Cadair authored and WilliamJamieson committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    af1ed6d View commit details
    Browse the repository at this point in the history

  23. We don't need to unit convert in API 

    It's done by call_forward/backward
    @Cadair @WilliamJamieson
    Cadair authored and WilliamJamieson committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    1a0bf13 View commit details
    Browse the repository at this point in the history

  24. Fix CelestialFrame units

    @Cadair @WilliamJamieson
    Cadair authored and WilliamJamieson committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    6adfbd2 View commit details
    Browse the repository at this point in the history

  25. More roundtip test fixing 

    Seems this leaves one troublesome test
    @Cadair @WilliamJamieson
    Cadair authored and WilliamJamieson committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    78a4d3c View commit details
    Browse the repository at this point in the history

  26. Fix roundtrip test by changing projection type

    @Cadair @WilliamJamieson
    Cadair authored and WilliamJamieson committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    65da6f5 View commit details
    Browse the repository at this point in the history

  27. Test and polish more ordering

    @Cadair @WilliamJamieson
    Cadair authored and WilliamJamieson committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    ccf8558 View commit details
    Browse the repository at this point in the history

  28. Make it so CompositeFrame follows the same ordering 

    This means that _prop is in native order and is sorted into axes order
    @Cadair @WilliamJamieson
    Cadair authored and WilliamJamieson committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    bd1d8ba View commit details
    Browse the repository at this point in the history

  29. Test and fix RegionSelector doctest fail

    @Cadair @WilliamJamieson
    Cadair authored and WilliamJamieson committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    8df8c2e View commit details
    Browse the repository at this point in the history

  30. lint

    @Cadair @WilliamJamieson
    Cadair authored and WilliamJamieson committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    09fe442 View commit details
    Browse the repository at this point in the history

  31. Fix duplicated pass_env / passenv config in tox 

    Also add some useful env vars
    @Cadair @WilliamJamieson
    Cadair authored and WilliamJamieson committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    f5cfbbd View commit details
    Browse the repository at this point in the history

  32. Some doc polish

    @Cadair @WilliamJamieson
    Cadair authored and WilliamJamieson committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    3e6a909 View commit details
    Browse the repository at this point in the history

  33. Fix rebase

    @Cadair @WilliamJamieson
    Cadair authored and WilliamJamieson committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    34dba84 View commit details
    Browse the repository at this point in the history

  34. Add high level <> values converters to frames 

    This adds back a more sane equivalent of coordinates and coordinates_to_quantity.
    @Cadair @WilliamJamieson
    Cadair authored and WilliamJamieson committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    bc8bbb4 View commit details
    Browse the repository at this point in the history

  35. Fix a apt bug

    @Cadair @WilliamJamieson
    Cadair authored and WilliamJamieson committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    bd84fc7 View commit details
    Browse the repository at this point in the history

  36. Fix a naxes bug

    @Cadair @WilliamJamieson
    Cadair authored and WilliamJamieson committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    3bcf81e View commit details
    Browse the repository at this point in the history

Commits on Nov 21, 2024

  1. Compat with astropy 7.0 for high_level methods

    @Cadair
    Cadair committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    a5a5b5e View commit details
    Browse the repository at this point in the history

  2. Explicitly error if invalid values

    @Cadair
    Cadair committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    ef38185 View commit details
    Browse the repository at this point in the history

  3. Raise an explicit error if mixed high level types are passed

    @Cadair
    Cadair committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    925d78f View commit details
    Browse the repository at this point in the history

  4. Test intermediate high_level conversion

    @Cadair
    Cadair committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    d3735c4 View commit details
    Browse the repository at this point in the history

Commits on Nov 25, 2024

  1. Whoops

    @Cadair
    Cadair committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    663a4cb View commit details
    Browse the repository at this point in the history