Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to Segmentation catalog to increase source detection #1630

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Commits on Jul 31, 2023

  1. Changed the variable names for the general "biggest source" and "bigg…

    …est source fraction"
    
    limits which were misleading, and added a new variable name to accommodate the RickerWavelet
    biggest source limit.
       OLD                       NEW
       _rw2d_biggest_source  ==> _biggest_source_limit
       _rw2d_source_fraction ==> _biggest_source_fraction_limit
        new                  ==> _rw_biggest_source_limit
    
    These changes required updating the catalog parameter JSON files, the code which reads
    the parameter values, and parameter names in segmentation source support functions.
    
    Clarified informational log messages when reporting the configuration limits in use for
    the Segmentation catalog.  Moved the computation of the ratio between the "Gaussian
    biggest source" and the "Rickerwavlet biggest source" to be computed, as well as applied,
    for Round 2. Added more informational messages to keep the user better informed.  Changed
    some limit values (though more changes will be needed for other detectors):
    
    ACS/WFC ONLY
       negative_percent: 15.0 ==> 20.0
       rw2d_nsigma: 10.0  ==> 40.0
    mdlpstsci committed Jul 31, 2023
    Configuration menu
    Copy the full SHA
    64cfcbb View commit details
    Browse the repository at this point in the history

Commits on Sep 18, 2023

  1. Configuration menu
    Copy the full SHA
    b835336 View commit details
    Browse the repository at this point in the history