Bump randomx-rs, don't override Mac SDK with old 12.3 #152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #152 +/- ##
=======================================
Coverage 93.85% 93.85%
=======================================
Files 24 24
Lines 2994 2994
=======================================
Hits 2810 2810
Misses 184 184 ☔ View full report in Codecov by Sentry. |
|
Works well on MacOS M1 👍 |
brusherru
approved these changes
Nov 23, 2023
andreivcodes
added a commit
to andreivcodes/post-rs
that referenced
this pull request
Dec 4, 2023
Merged
andreivcodes
added a commit
to andreivcodes/post-rs
that referenced
this pull request
Dec 4, 2023
This reverts commit 075d253.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new randomx-rs version uses a newer RandomX v1.2.1, that fixed tevador/RandomX#262. We don't need to build using an older Mac SDK anymore.