Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - support dns addresses #3180

Closed
wants to merge 3 commits into from

Conversation

abergasov
Copy link
Contributor

@abergasov abergasov commented Apr 19, 2022

Motivation

Now for bootnodes can be used links with dns addresses.
DNS resolve address on connect
Closes #3156

Changes

Test Plan

DevOps Notes

  • This PR does not require configuration changes (e.g., environment variables, GitHub secrets, VM resources)
  • This PR does not affect public APIs
  • This PR does not rely on a new version of external services (PoET, elasticsearch, etc.)
  • This PR does not make changes to log messages (which monitoring infrastructure may rely on)

@abergasov abergasov marked this pull request as ready for review April 20, 2022 09:39
Copy link
Contributor

@dshulyak dshulyak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it possible to add some meaningful (unit) test? for example:

  1. add dns addr to the address book manually, spawn protocol server
  2. query addresses from protocol server
  3. check that dns address was added to the local address book

Copy link
Contributor

@dshulyak dshulyak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

linter failed

@abergasov abergasov force-pushed the 3156-p2p-support-dns-entrypoints_v2 branch from 078068a to c5d145b Compare April 27, 2022 09:14
@dshulyak
Copy link
Contributor

bors merge

bors bot pushed a commit that referenced this pull request Apr 28, 2022
## Motivation
Now for bootnodes can be used links with dns addresses.
DNS resolve address on connect
Closes #3156

## Changes
<!-- Please describe in detail the changes made -->

## Test Plan
<!-- Please specify how these changes were tested 
(e.g. unit tests, manual testing, etc.) -->

## DevOps Notes
<!-- Please uncheck these items as applicable to make DevOps aware of changes that may affect releases -->
- [x] This PR does not require configuration changes (e.g., environment variables, GitHub secrets, VM resources)
- [x] This PR does not affect public APIs
- [x] This PR does not rely on a new version of external services (PoET, elasticsearch, etc.)
- [x] This PR does not make changes to log messages (which monitoring infrastructure may rely on)


Co-authored-by: Eugene Toropov <[email protected]>
@bors
Copy link

bors bot commented Apr 28, 2022

Pull request successfully merged into develop.

Build succeeded:

@bors bors bot changed the title support dns addresses [Merged by Bors] - support dns addresses Apr 28, 2022
@bors bors bot closed this Apr 28, 2022
@bors bors bot deleted the 3156-p2p-support-dns-entrypoints_v2 branch April 28, 2022 04:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

p2p: support dns entrypoints
4 participants