-
Notifications
You must be signed in to change notification settings - Fork 211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
logging: support log collection from external smeshers #3134
Labels
Comments
With loki there is simpler version of the client . it needs to be integrated as a WriteSyncer to zap.Core . The client itself batches log entries in the background and instrumented with relevant metrics, so that we will know if logger will use a lot of traffic. |
4 tasks
bors bot
pushed a commit
that referenced
this issue
Aug 5, 2022
## Motivation <!-- Please mention the issue fixed by this PR or detailed motivation --> part of #3134 <!-- `Closes #XXXX, closes #XXXX, ...` links mentioned issues to this PR and automatically closes them when this it's merged --> ## Changes <!-- Please describe in detail the changes made --> using systests TestAddNodes as measurement of the log file for a node. - before 4.3M - with hare reduced 1.6M (1st commit) (-62.79%) - with the rest of the change 1.2M (-9.3%)
github-project-automation
bot
moved this from 🏗 In progress
to ✅ Done
in Dev iterations
Aug 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We are missing important information that are required to troubleshoot concurrency-related issues. For instance in devnet220 in layer 8345 there are 2 proposals that are created with old base ballots and without votes for recent layers. It indicates that the hare didn't complete on those smeshers, while the rest of the cluster completed hare successfully.
There are two options:
I prefer to go with 1st option
The text was updated successfully, but these errors were encountered: