Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve file thumbnails and Quick Preview (+ some code clean-up and rust deps update) #2758

Merged
merged 24 commits into from
Oct 21, 2024

Conversation

HeavenVolkoff
Copy link
Member

@HeavenVolkoff HeavenVolkoff commented Oct 10, 2024

  • Deleted some unused examples and React hooks, plus some fully commented out frontend code
  • Update Tanstack to v5
  • Update tauri, axum, rspc, prisma-client-rust and rust-lip2p
  • Implement many changes required due to the updates above
  • Fix thumbnail flickering (I hope this time for good)
  • Fix QuickPreview showing incorrect previews sometimes

Closes: ENG-1800, ENG-1221, ENG-1549, ENG-948, ENG-1385

Copy link

vercel bot commented Oct 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
spacedrive-landing ⬜️ Ignored (Inspect) Visit Preview Oct 21, 2024 11:41am
spacedrive-web ⬜️ Ignored (Inspect) Visit Preview Oct 21, 2024 11:41am

Copy link
Member

@matheus-consoli matheus-consoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Rust part looks good to me!
I commented on one change that can be simplified, but it isn't blocking - feel free to ignore it.

apps/desktop/src-tauri/src/tauri_plugins.rs Outdated Show resolved Hide resolved
 - Deleted some unused examples and fully commented out frontend code
 - Implement many changes required due to the updates
 - Update most rust dependencies
 - Update some github actions
 - Update pnpm lock file
 - Fix million complaining about Sparkles component
 - Fix core always saying a new thumbnail was generated even for files that it skiped thumbnail generation
 - Rewrite FileThumb and improve related components
 - Rework useExplorerDraggable and useExplorerItemData hooks due to reduce unecessary re-renders
 - A couple of minor performance improvements to frontend code
@HeavenVolkoff HeavenVolkoff added this pull request to the merge queue Oct 21, 2024
Merged via the queue into main with commit ea92383 Oct 21, 2024
13 checks passed
@HeavenVolkoff HeavenVolkoff deleted the update-deps branch October 21, 2024 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants