-
-
Notifications
You must be signed in to change notification settings - Fork 946
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve file thumbnails and Quick Preview (+ some code clean-up and rust deps update) #2758
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Skipped Deployments
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Rust part looks good to me!
I commented on one change that can be simplified, but it isn't blocking - feel free to ignore it.
HeavenVolkoff
changed the title
Update rspc, prisma-client-rust, axum and tanstack-query
Improve file thumbnails and Quick Preview (+ some code clean-up and rust deps update)
Oct 16, 2024
- Deleted some unused examples and fully commented out frontend code - Implement many changes required due to the updates - Update most rust dependencies
- Update some github actions - Update pnpm lock file
- Fix million complaining about Sparkles component
- Fix core always saying a new thumbnail was generated even for files that it skiped thumbnail generation - Rewrite FileThumb and improve related components
- Rework useExplorerDraggable and useExplorerItemData hooks due to reduce unecessary re-renders
- A couple of minor performance improvements to frontend code
HeavenVolkoff
force-pushed
the
update-deps
branch
from
October 18, 2024 13:33
b651144
to
cfd327d
Compare
HeavenVolkoff
force-pushed
the
update-deps
branch
from
October 18, 2024 14:42
dbfa723
to
57a943c
Compare
ameer2468
approved these changes
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: ENG-1800, ENG-1221, ENG-1549, ENG-948, ENG-1385