MacOS: Fix video intro #2165
Merged
MacOS: Fix video intro #2165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
utkubakir
approved these changes
Mar 5, 2024
ameer2468
added a commit
that referenced
this pull request
Mar 6, 2024
* macos use mp4 - others use webm * macos use mp4 - others use webm
github-merge-queue bot
pushed a commit
that referenced
this pull request
Mar 11, 2024
* mobile search filters wip * Layout transitions * mob search wip * mob search button actions * MacOS: Fix video intro (#2165) * macos use mp4 - others use webm * macos use mp4 - others use webm * [ENG-1662] Fix thumb black bars (#2167) fix resize loop * [ENG-1661] Windows explorer scrollbar (#2166) Fix windows scrollbar * [ENG-1663] Prevent middle-click opening new tab (#2168) Update Link.tsx * [MOB-23] Mobile Hardware Information for Overview Page (#2106) * wip for iDevices * Working HardwareModel Info for iOS * wip * Merge 'main' into 'mob-hw-info-overview' * Half-Working `get_volume()` * Objective c bridge to talk to FS * Working objc bridge The bridge works now, and we can now access the iOS file system using the native objective-c APIs instead for proper values, including on the simulator. * Isolate `icrate` for `ios` deployments only * Working Stats for Android * Clean Up + `pnpm format` * Fix to FSInfoResult Type Due to the RNFS fork change, I had to change the types to make it so it doesn't fail building and CI. * iOS Device Name Fix * paginate sync backfill (#2163) * paginate sync backfill * add backfill timeout * use gt instead of gte * Revert Tracing-Subscriber filter level (#2169) Update lib.rs Forgot to update the tracing-subscriber level from debug to info. Oops. * Layout transitions * Filters bar wip * Code improvements * mob search: in its finals - more ui tweaks coming * pr adjustments * Mob search * Update pnpm-lock.yaml * github glitch? * Create Filters.tsx * improve switch statement and remove empty string values * Update FiltersBar.tsx * Update FiltersBar.tsx --------- Co-authored-by: nikec <[email protected]> Co-authored-by: Arnab Chakraborty <[email protected]> Co-authored-by: Brendan Allan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue is most likely associated with how Tauri handles building when webm videos are involved with MacOS. It still is not fully clear how it works in dev, but not in production. However, there are reports related this issue.
Tested on both: MacOS & Windows and has passed successfully.