Remove enableElevatedUpdateTask from Wix installer config
#2004
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This config option seems to be crashing the installer for a lot of Windows users, and I am not 100% why I enabled anyway, so revert it
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
ameer2468
approved these changes
Jan 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This config option seems to be crashing the installer for a lot of Windows users, and I am not 100% why I enabled anyway, so revert it.
Rationale:
According to this log, from an affected user:
#1994 (comment)
The problem steams from the
CreateUpdateTaskaction present in tauri's Wix template:https://github.com/tauri-apps/tauri/blob/tauri-v1.5.3/tooling/bundler/src/bundle/windows/templates/main.wxs#L282-L307
Which tries to execute this Powershell script:
https://github.com/tauri-apps/tauri/blob/tauri-v1.5.3/tooling/bundler/src/bundle/windows/templates/install-task.ps1
That fails for a lot of our users for some reason.
However, this is a non-default behavior that I enabled in the AI PR for some reason (maybe by mistake):
https://github.com/spacedriveapp/spacedrive/pull/1845/files#diff-25f93a9e45647c833a5769e5c21fb1735e0ffd08f536dad2337de462ed7d14ddR47
https://tauri.app/v1/api/config#wixconfig.enableelevatedupdatetask
The best solution is to revert this for now
Close #1994