Update regex to match periods in GitHub URL (#194) #242
Annotations
6 warnings
explicit call to `.into_iter()` in function argument accepting `IntoIterator`:
spr/src/error.rs#L156
warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator`
--> spr/src/error.rs:156:35
|
156 | e.messages.extend(error.messages.into_iter());
| ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `error.messages`
|
note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()`
--> /rustc/9b00956e56009bab2aa15d7bff10916599e3d6d6/library/core/src/iter/traits/collect.rs:415:18
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
= note: `#[warn(clippy::useless_conversion)]` on by default
|
accessing first element with `pr_commit_parents.get(0)`:
spr/src/commands/diff.rs#L515
warning: accessing first element with `pr_commit_parents.get(0)`
--> spr/src/commands/diff.rs:515:12
|
515 | if pr_commit_parents.get(0) != Some(&oid) {
| ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `pr_commit_parents.first()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first
|
assigning the result of `Clone::clone()` may be inefficient:
spr/src/commands/diff.rs#L501
warning: assigning the result of `Clone::clone()` may be inefficient
--> spr/src/commands/diff.rs:501:9
|
501 | *message_on_prompt = input.clone();
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `clone_from()`: `message_on_prompt.clone_from(&input)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assigning_clones
= note: `#[warn(clippy::assigning_clones)]` on by default
|
accessing first element with `prepared_commits.get(0)`:
spr/src/commands/diff.rs#L66
warning: accessing first element with `prepared_commits.get(0)`
--> spr/src/commands/diff.rs:66:55
|
66 | let master_base_oid = if let Some(first_commit) = prepared_commits.get(0) {
| ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `prepared_commits.first()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first
= note: `#[warn(clippy::get_first)]` on by default
|
clippy_check
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions-rs/clippy-check@v1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
clippy_check
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|