-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: timestamp inequality support #52
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm where did you actually compare timestamps? Moreover how do you do it with different timezones?
I would point you to this test here which is probably the most significant example, this test confirms that our approach matches that of postgres. I have also added many other examples in this PR which test inequalities on various timezones as you pointed out coverage was lacking in those areas |
@drcapybara BTW it will be really great if you use |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really thanks for submitting and repeatedly modifying this PR! I really appreciate this!
🎉 This PR is included in version 0.5.8 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Rationale for this change
Quick PR to add support for inequality expressions between timestamps. Since theyre represented internally as i64, they can be easily compared against one another.
What changes are included in this PR?
Adds support for statements with the following syntax:
Are these changes tested?
yes