refactor: remove base::sqlparser::ident since into() is simpler
#437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iajoiner
force-pushed
the
refactor/rem-helper
branch
2 times, most recently
from
4d1b9cf to
b72b6c6
Compare
varshith257
approved these changes
Dec 16, 2024
Dustin-Ray
reviewed
Dec 16, 2024
Comment on lines
+35
to
+36
| "boolean_column".into(), | ||
| ColumnRef::new(tab_ref, "boolean_column".into(), ColumnType::Boolean), |
There was a problem hiding this comment.
Are these always strings? Why not simplify this and abstract the into() conversions away so that the K,V pair becomes String, ColumnRef or &str, ColumnRef, same comment with the ColumnRef new field
There was a problem hiding this comment.
@Dustin-Ray These are sqlparser::ast::Idents. That's the easiest way to construct an Ident from a string.
There was a problem hiding this comment.
@Dustin-Ray We used to use Identifier and now use Ident. Strings don't really one-on-one map to Ident.
iajoiner
force-pushed
the
refactor/rem-helper
branch
from
b72b6c6 to
ce4274d
Compare
|
🎉 This PR is included in version 0.63.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please be sure to look over the pull request guidelines here: https://github.com/spaceandtimelabs/sxt-proof-of-sql/blob/main/CONTRIBUTING.md#submit-pr.
Please go through the following checklist
!is used if and only if at least one breaking change has been introduced.source scripts/run_ci_checks.sh.Rationale for this change
This change simplifies the codebase since
proof_of_sql::base::sqlparser::identonly does one thing which is to callFrom<&str>onIdent. Let's simplify the codebase here.What changes are included in this PR?
See title.
Are these changes tested?
Yes.