refactor: make dynamic dory helper code generic #424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stuarttimwhite
force-pushed
the
refactor/make-dynamic-dory-helper-code-generic
branch
2 times, most recently
from
02c2d30 to
fe7ceee
Compare
stuarttimwhite
requested review from
jacobtrombetta,
JayWhite2357 and
Dustin-Ray
and removed request for
jacobtrombetta
iajoiner
changed the title
stuarttimwhite
force-pushed
the
refactor/make-dynamic-dory-helper-code-generic
branch
2 times, most recently
from
4cc7deb to
77da6bf
Compare
Dustin-Ray
reviewed
Dec 11, 2024
crates/proof-of-sql/src/proof_primitive/dory/dynamic_build_vmv_state.rs
Outdated
Show resolved
Hide resolved
Dustin-Ray
reviewed
Dec 11, 2024
...roof-of-sql/src/proof_primitive/dynamic_dory_and_hyrax_common_utils/standard_basis_helper.rs
Outdated
Show resolved
Hide resolved
Dustin-Ray
reviewed
Dec 11, 2024
| alphas: &[F], | ||
| alpha_invs: &[F], | ||
| ) -> (F, F) { | ||
| pub(crate) fn fold_dynamic_standard_basis_tensors<S: Scalar, I: Into<S> + From<S> + Copy>( |
There was a problem hiding this comment.
NIT: This needs a doc comment please
There was a problem hiding this comment.
This is not a new function.
Dustin-Ray
reviewed
Dec 11, 2024
Dustin-Ray
reviewed
Dec 11, 2024
...roof-of-sql/src/proof_primitive/dynamic_dory_and_hyrax_common_utils/standard_basis_helper.rs
Outdated
Show resolved
Hide resolved
Dustin-Ray
reviewed
Dec 11, 2024
...roof-of-sql/src/proof_primitive/dynamic_dory_and_hyrax_common_utils/standard_basis_helper.rs
Outdated
Show resolved
Hide resolved
Dustin-Ray
reviewed
Dec 11, 2024
...roof-of-sql/src/proof_primitive/dynamic_dory_and_hyrax_common_utils/standard_basis_helper.rs
Outdated
Show resolved
Hide resolved
Dustin-Ray
reviewed
Dec 11, 2024
...roof-of-sql/src/proof_primitive/dynamic_dory_and_hyrax_common_utils/standard_basis_helper.rs
Outdated
Show resolved
Hide resolved
Dustin-Ray
reviewed
Dec 11, 2024
crates/proof-of-sql/src/proof_primitive/dynamic_dory_and_hyrax_common_utils/mod.rs
Outdated
Show resolved
Hide resolved
Dustin-Ray
reviewed
Dec 11, 2024
...roof-of-sql/src/proof_primitive/dynamic_dory_and_hyrax_common_utils/standard_basis_helper.rs
Outdated
Show resolved
Hide resolved
...roof-of-sql/src/proof_primitive/dynamic_dory_and_hyrax_common_utils/standard_basis_helper.rs
Outdated
Show resolved
Hide resolved
stuarttimwhite
force-pushed
the
refactor/make-dynamic-dory-helper-code-generic
branch
from
77da6bf to
b039952
Compare
stuarttimwhite
force-pushed
the
refactor/make-dynamic-dory-helper-code-generic
branch
from
b039952 to
6617c1d
Compare
crates/proof-of-sql/src/proof_primitive/dory/dynamic_build_vmv_state.rs
Outdated
Show resolved
Hide resolved
stuarttimwhite
force-pushed
the
refactor/make-dynamic-dory-helper-code-generic
branch
from
6617c1d to
a458ba5
Compare
…nd peeling slices
JayWhite2357
approved these changes
Dec 12, 2024
stuarttimwhite
deleted the
refactor/make-dynamic-dory-helper-code-generic
branch
|
🎉 This PR is included in version 0.62.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please be sure to look over the pull request guidelines here: https://github.com/spaceandtimelabs/sxt-proof-of-sql/blob/main/CONTRIBUTING.md#submit-pr.
Please go through the following checklist
!is used if and only if at least one breaking change has been introduced.source scripts/run_ci_checks.sh.Rationale for this change
There will be a new Hyrax commitment evaluation scheme which will use much existing common code from dynamic dory. This is preliminary work to make that code centralized.
What changes are included in this PR?
Are these changes tested?
Existing dynamic dory tests are modified to use the generic code.