fix!: fix GroupByExec input length in proof && move GroupByExec top level restriction to GroupByExec itself
#407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iajoiner
changed the title
GroupByExec so that it is composable with othersGroupByExec input length in proof
- fix `GroupByExec` input length - move `GroupByExec` must be top level logic to `GroupByExec` itself
iajoiner
force-pushed
the
fix/groupby-proof
branch
from
0966227 to
63b6843
Compare
iajoiner
changed the title
GroupByExec input length in proofGroupByExec input length in proof && move GroupByExec top level restriction to GroupByExec itself
JayWhite2357
approved these changes
Dec 4, 2024
|
🎉 This PR is included in version 0.57.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please be sure to look over the pull request guidelines here: https://github.com/spaceandtimelabs/sxt-proof-of-sql/blob/main/CONTRIBUTING.md#submit-pr.
Please go through the following checklist
!is used if and only if at least one breaking change has been introduced.source scripts/run_ci_checks.sh.Rationale for this change
This PR is partly the equivalent of #401 for
GroupbyExec. Moreover we should move the temporaryGroupByExectop level restriction toGroupByExecitself so that we don't have to keep it everywhere.What changes are included in this PR?
GroupByExec.GroupByExeccomposition restriction toGroupByExecitself.Are these changes tested?
Existing tests should pass.