refactor!: replace DataAccessor in ProofPlan with IndexMap
#372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iajoiner
force-pushed
the
refactor/unify-accessors
branch
9 times, most recently
from
6c7f272 to
1dd3d84
Compare
iajoiner
force-pushed
the
refactor/unify-accessors
branch
from
1dd3d84 to
e91e866
Compare
iajoiner
force-pushed
the
refactor/unify-accessors
branch
3 times, most recently
from
4947894 to
ce59508
Compare
…eRef, Table<'a, S>>`
iajoiner
force-pushed
the
refactor/unify-accessors
branch
from
ce59508 to
9acba0e
Compare
JayWhite2357
approved these changes
Nov 18, 2024
|
🎉 This PR is included in version 0.48.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please be sure to look over the pull request guidelines here: https://github.com/spaceandtimelabs/sxt-proof-of-sql/blob/main/CONTRIBUTING.md#submit-pr.
Please go through the following checklist
!is used if and only if at least one breaking change has been introduced.source scripts/run_ci_checks.sh.Rationale for this change
This is the next step in making
ProofPlancomposable. Let's centralize fetching of table maps usingDataAccessortoquery_proof.rs.What changes are included in this PR?
See above.
Are these changes tested?
Existing tests do pass.