refactor!: split and simplify owned_column_operation.rs && remove unused functions from slice_operation.rs

[iajoiner]

Please be sure to look over the pull request guidelines here: https://github.com/spaceandtimelabs/sxt-proof-of-sql/blob/main/CONTRIBUTING.md#submit-pr.

Please go through the following checklist

• The PR title and commit messages adhere to guidelines here: https://github.com/spaceandtimelabs/sxt-proof-of-sql/blob/main/CONTRIBUTING.md. In particular ! is used if and only if at least one breaking change has been introduced.
• I have run the ci check script with source scripts/run_ci_checks.sh.

Rationale for this change

owned_column_operation.rs is extremely tedious hence we need to simplify it.

What changes are included in this PR?

• split out arithmetic operations into column_arithmetic_operation.rs and unify them.
• split out comparison operations into column_comparison_operation.rs and unify them.
• remove unused functions.

Are these changes tested?

Yes.

[JayWhite2357]

Here's my suggestion:

pub fn element_wise_add<S: Scalar>(
    lhs: &OwnedColumn<S>,
    rhs: &OwnedColumn<S>,
) -> ColumnOperationResult<OwnedColumn<S>> {
    struct AddOp {}
    impl ArithmeticOp for AddOp {
        fn op<T>(l: &T, r: &T) -> ColumnOperationResult<T>
        where
            T: CheckedAdd + Debug,
        {
            try_add(l, r)
        }

        fn decimal_op<S, T0, T1>(
            lhs: &[T0],
            rhs: &[T1],
            left_column_type: ColumnType,
            right_column_type: ColumnType,
        ) -> ColumnOperationResult<(Precision, i8, Vec<S>)>
        where
            S: Scalar + From<T0> + From<T1>,
            T0: Copy,
            T1: Copy,
        {
            try_add_decimal_columns(lhs, rhs, left_column_type, right_column_type)
        }
    }
    AddOp::element_wise_arithmetic(lhs, rhs)
}

pub fn element_wise_sub<S: Scalar>(
    lhs: &OwnedColumn<S>,
    rhs: &OwnedColumn<S>,
) -> ColumnOperationResult<OwnedColumn<S>> {
    struct SubOp {}
    impl ArithmeticOp for SubOp {
        fn op<T>(l: &T, r: &T) -> ColumnOperationResult<T>
        where
            T: CheckedSub + Debug,
        {
            try_sub(l, r)
        }

        fn decimal_op<S, T0, T1>(
            lhs: &[T0],
            rhs: &[T1],
            left_column_type: ColumnType,
            right_column_type: ColumnType,
        ) -> ColumnOperationResult<(Precision, i8, Vec<S>)>
        where
            S: Scalar + From<T0> + From<T1>,
            T0: Copy,
            T1: Copy,
        {
            try_subtract_decimal_columns(lhs, rhs, left_column_type, right_column_type)
        }
    }
    SubOp::element_wise_arithmetic(lhs, rhs)
}

trait ArithmeticOp {
    fn op<T>(l: &T, r: &T) -> ColumnOperationResult<T>
    where
        T: CheckedAdd + Debug;
    fn decimal_op<S, T0, T1>(
        lhs: &[T0],
        rhs: &[T1],
        left_column_type: ColumnType,
        right_column_type: ColumnType,
    ) -> ColumnOperationResult<(Precision, i8, Vec<S>)>
    where
        S: Scalar + From<T0> + From<T1>,
        T0: Copy,
        T1: Copy;

    fn element_wise_arithmetic<S: Scalar>(
        lhs: &OwnedColumn<S>,
        rhs: &OwnedColumn<S>,
    ) -> ColumnOperationResult<OwnedColumn<S>> {
        if lhs.len() != rhs.len() {
            return Err(ColumnOperationError::DifferentColumnLength {
                len_a: lhs.len(),
                len_b: rhs.len(),
            });
        }
        match (&lhs, &rhs) {
            (OwnedColumn::TinyInt(lhs), OwnedColumn::TinyInt(rhs)) => Ok(OwnedColumn::TinyInt(
                try_slice_binary_op(lhs, rhs, Self::op)?,
            )),
            // remaining branches
            _ => Err(ColumnOperationError::BinaryOperationInvalidColumnType {
                operator: BinaryOperator::Add,
                left_type: lhs.column_type(),
                right_type: rhs.column_type(),
            }),
        }
    }
}

[JayWhite2357]

Looks great! Will approve after rebase. Why is this a breaking change?

[iajoiner]

@JayWhite2357 It is breaking since we removed the awkward Add, Sub, Mul and Div from OwnedColumn<S> which is public. We don't expect downstream projects to use these but they may.

[github-actions]

🎉 This PR is included in version 0.42.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀