refactor!: remove parser structs from ColumnOperationError
#344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iajoiner
force-pushed
the
refactor/col-op-err
branch
2 times, most recently
from
c5b70bb to
dd85f23
Compare
iajoiner
force-pushed
the
refactor/col-op-err
branch
from
dd85f23 to
086b832
Compare
2 tasks
JayWhite2357
approved these changes
Nov 11, 2024
… string This makes it easier to migrate from a particular implementation of parser and remove the need to pass in UnaryOp / BinaryOp
iajoiner
force-pushed
the
refactor/col-op-err
branch
from
086b832 to
4b46324
Compare
|
🎉 This PR is included in version 0.40.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please be sure to look over the pull request guidelines here: https://github.com/spaceandtimelabs/sxt-proof-of-sql/blob/main/CONTRIBUTING.md#submit-pr.
Please go through the following checklist
!is used if and only if at least one breaking change has been introduced.source scripts/run_ci_checks.sh.Rationale for this change
This change is made to simplify column operations partly in order to simplify
owned_column_operation.rsand partly in preparation for the new version of provable arithmetic expressions.What changes are included in this PR?
BinaryOpandUnaryOpinColumnOperationErrorwith stringsAre these changes tested?
Existing tests should pass