Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add to config.toml and unify fmt customization #337

Merged
merged 1 commit into from
Nov 6, 2024
Merged

Conversation

iajoiner
Copy link
Contributor

@iajoiner iajoiner commented Nov 4, 2024

Please be sure to look over the pull request guidelines here: https://github.com/spaceandtimelabs/sxt-proof-of-sql/blob/main/CONTRIBUTING.md#submit-pr.

Please go through the following checklist

Rationale for this change

The rustfmt config used in CI is tedious to type hence it is helpful to add it as an alias to config.toml.

What changes are included in this PR?

  • add cargo f and cargo cl aliases to config.toml
  • remove fmt customization from CI to unify it

Are these changes tested?

Yes

.github/workflows/lint-and-test.yml Outdated Show resolved Hide resolved
.github/workflows/lint-and-test.yml Outdated Show resolved Hide resolved
.github/workflows/lint-and-test.yml Outdated Show resolved Hide resolved
JayWhite2357
JayWhite2357 previously approved these changes Nov 4, 2024
@iajoiner iajoiner changed the title ci: add rustfmt.toml and remove rustfmt config from ci ci: remove unnecessary fmt customization from CI Nov 5, 2024
@iajoiner iajoiner requested a review from JayWhite2357 November 5, 2024 14:43
@iajoiner iajoiner force-pushed the ci/rustfmt branch 3 times, most recently from 565f1a6 to 3247bd9 Compare November 5, 2024 18:24
@iajoiner iajoiner changed the title ci: remove unnecessary fmt customization from CI ci: add to config.toml and unify fmt customization Nov 5, 2024
Copy link
Contributor

@JayWhite2357 JayWhite2357 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@iajoiner iajoiner merged commit d66e769 into main Nov 6, 2024
12 checks passed
Copy link

github-actions bot commented Nov 6, 2024

🎉 This PR is included in version 0.35.6 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@iajoiner iajoiner deleted the ci/rustfmt branch November 12, 2024 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants