Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/add stocks dataset example #319

Merged
merged 15 commits into from
Oct 29, 2024
Merged

Conversation

waelsy123
Copy link
Contributor

@waelsy123 waelsy123 commented Oct 25, 2024

Rationale for this change

  • More test example in the repo provide better documentation

What changes are included in this PR?

  • stock market dataset
  • script to run the test

Are these changes tested?

Yes

@aw-sxt aw-sxt removed their request for review October 25, 2024 13:04
@Dustin-Ray
Copy link
Contributor

Hi @waelsy123 would you mind resolving the merge conflict real quick and then we can go ahead and merge? Thanks

AlejandroLanaspa and others added 3 commits October 29, 2024 03:07
# Rationale for this change

Add an additional movies example to help improve documentation.

# What changes are included in this PR?

movies example is added.

# Are these changes tested?
No
@waelsy123
Copy link
Contributor Author

Hi @waelsy123 would you mind resolving the merge conflict real quick and then we can go ahead and merge? Thanks

conflicts resolved

Copy link
Contributor

@Dustin-Ray Dustin-Ray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Dustin-Ray Dustin-Ray merged commit ab969f3 into main Oct 29, 2024
12 checks passed
Copy link

🎉 This PR is included in version 0.34.6 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants