Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refact: remove Into<[u64; 4]>, From<[u64; 4]>, and RefInto<[u64; 4]> bounds for trait Scalar #258

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

SuccinctPaul
Copy link

@SuccinctPaul SuccinctPaul commented Oct 11, 2024

It's only a draft.

What changes are included in this PR?

  • remove Into<[u64; 4]>, From<[u64; 4]>, and RefInto<[u64; 4]> bounds for trait Scalar

Are these changes tested?

Copy link
Contributor

@JayWhite2357 JayWhite2357 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quickly glancing over this looks good so far. You mention that it is a draft. I marked it as a Draft PR. Once you feel it is ready, go ahead and mark it as ready for review.

@JayWhite2357 JayWhite2357 marked this pull request as draft October 11, 2024 05:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants