refactor!: rename ResultBuilder to FirstRoundBuilder, ProofBuilder to FinalRoundBuilder && split first round proof out of ProofPlan::result_evaluate
#257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iajoiner
changed the title
ResultBuilder to FirstRoundBuilderResultBuilder to FirstRoundBuilder, ProofBuilder to FinalRoundBuilder && split first round proof out of result_evaluate
iajoiner
changed the title
ResultBuilder to FirstRoundBuilder, ProofBuilder to FinalRoundBuilder && split first round proof out of result_evaluateResultBuilder to FirstRoundBuilder, ProofBuilder to FinalRoundBuilder && split first round proof out of ProofPlan::result_evaluate
2 tasks
- rename `ResultBuilder` to `FirstRoundBuilder` - rename `proof-of-sql/src/sql/proof/result_builder.rs` to `first_round_builder.rs`
- rename `ProofBuilder` to `FinalRoundBuilder` - rename `proof-of-sql/src/sql/proof/proof_builder.rs` to `final_round_builder.rs`
…luate` - split out post result challenges into `ProofPlan::first_round_evaluate` - replace `FirstRoundBuilder` in `result_evaluate` with `input_length`
JayWhite2357
force-pushed
the
refactor/rounds
branch
from
e594ca8 to
42f3069
Compare
2 tasks
iajoiner
added a commit
that referenced
this pull request
Dec 4, 2024
Please be sure to look over the pull request guidelines here: https://github.com/spaceandtimelabs/sxt-proof-of-sql/blob/main/CONTRIBUTING.md#submit-pr. # Please go through the following checklist - [x] The PR title and commit messages adhere to guidelines here: https://github.com/spaceandtimelabs/sxt-proof-of-sql/blob/main/CONTRIBUTING.md. In particular `!` is used if and only if at least one breaking change has been introduced. - [x] I have run the ci check script with `source scripts/run_ci_checks.sh`. # Rationale for this change Since we are adding range check which will require `FirstRoundBuilder` to read query results we partly undo #257 and merge `ProofPlan::result_evaluate` back into `ProofPlan::first_round_evaluate`. <!-- Why are you proposing this change? If this is already explained clearly in the linked issue then this section is not needed. Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes. Example: Add `NestedLoopJoinExec`. Closes #345. Since we added `HashJoinExec` in #323 it has been possible to do provable inner joins. However performance is not satisfactory in some cases. Hence we need to fix the problem by implement `NestedLoopJoinExec` and speed up the code for `HashJoinExec`. --> # What changes are included in this PR? See above. <!-- There is no need to duplicate the description in the ticket here but it is sometimes worth providing a summary of the individual changes in this PR. Example: - Add `NestedLoopJoinExec`. - Speed up `HashJoinExec`. - Route joins to `NestedLoopJoinExec` if the outer input is sufficiently small. --> # Are these changes tested? <!-- We typically require tests for all PRs in order to: 1. Prevent the code from being accidentally broken by subsequent changes 2. Serve as another way to document the expected behavior of the code If tests are not included in your PR, please explain why (for example, are they covered by existing tests)? Example: Yes. --> Yes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please be sure to look over the pull request guidelines here: https://github.com/spaceandtimelabs/sxt-proof-of-sql/blob/main/CONTRIBUTING.md#submit-pr.
Please go through the following checklist
!is used if and only if at least one breaking change has been introduced.source scripts/run_ci_checks.sh.Rationale for this change
ResultBuilderisn't really needed forresult_evaluatewhen all we need are input table lengths. However it is crucial in producing the query proof. Hence we need to remove it from the actual query result computation process (expr.result_evaluate). At the same time it should be correctly named as builder of the first round of the proof because that's what it is.What changes are included in this PR?
The 4 commits are supposed to be reviewed individually.
ResultBuildertoFirstRoundBuilder,ProofBuildertoFinalRoundBuilder.proof-of-sql/src/sql/proof/result_builder.rstofirst_round_builder.rs,proof-of-sql/src/sql/proof/proof_builder.rstofinal_round_builder.rs.ProofPlan::first_round_evaluateFirstRoundBuilderinresult_evaluatewithinput_lengthProverEvaluate::prover_evaluatetofinal_round_evaluateAre these changes tested?
Yes