perf: the dynamic Dory commitment computation should have a GPU implementation #247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mic_dory_commitment_helper_gpu module
… create
metadata tables that are used to call Blitzar's vlen_msm function
…r's vlen_msm function
JayWhite2357
previously approved these changes
Oct 10, 2024
crates/proof-of-sql/src/proof_primitive/dory/dynamic_dory_commitment_helper_gpu.rs
Show resolved
Hide resolved
JayWhite2357
force-pushed
the
perf/dynamic-dory-gpu
branch
from
7c2a4e9 to
6b14187
Compare
JayWhite2357
previously approved these changes
Oct 12, 2024
JayWhite2357
force-pushed
the
perf/dynamic-dory-gpu
branch
from
6b14187 to
d820af9
Compare
…mic_dory_commitment_helper_gpu module
… create
metadata tables that are used to call Blitzar's vlen_msm function
…r's vlen_msm function
JayWhite2357
force-pushed
the
perf/dynamic-dory-gpu
branch
from
d820af9 to
78c26d4
Compare
JayWhite2357
previously approved these changes
Oct 12, 2024
…melabs/sxt-proof-of-sql into perf/dynamic-dory-gpu
* tests are added to check when there are no sub commits
tlovell-sxt
approved these changes
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
The Blitzar project implemented a
vlen_msmfunction that is optimized for the dynamic Dory structure. This PR creates thedynamic_dory_commitment_helper_gpumodule when using the blitzar feature flag. Helper functions are added that create the input needed for Blitzar's vlen_msm function.This work is the final piece of a PR that was split up: #231.
What changes are included in this PR?
#[allow(dead_code)]tags are removed from thedynamic_dory_structuremodule.pack_scalars::min_as_fis made public - this will likely need refactored in a follow up PR when thecompute_dynamic_T_vec_primeis ported to the GPU.Are these changes tested?
Yes