feat: refactor Commitment trait to return Vec<Self> instead of mutating slice

[Gmin2]

Rationale for this change

Mentioned in #165

What changes are included in this PR?

• Modified the Commitment trait's compute_commitments method to return Vec<Self> instead of mutating a pre-allocated slice.
• Updated implementations for NaiveCommitment, DoryCommitment, and DynamicDoryCommitment to align with the new trait definition.

Fixes #165
/claim #165

[Dustin-Ray]

@Gmin2 Thanks a bunch for the effort on this, can you please check our CI and ensure that clippy and cargo fmt have been run as currently these appear to be failing in the CI. Thank you! Feel free to request a review when these items are addressed.

[JayWhite2357]

Looks good to me. Just run cargo fmt and clean up the clippy lint, and it will be good to go!
We run both of the following in CI:

cargo fmt --all -- --config imports_granularity=Crate,group_imports=One
cargo clippy --all-targets --all-features -- -D warnings

[Gmin2]

Just run cargo fmt and clean up the clippy lint, and it will be good to go!
We run both of the following in CI:

@JayWhite2357 , done with the changes

[JayWhite2357]

/approve

[algora-pbc]

@JayWhite2357: The claim has been successfully added to reward-all. You can visit your dashboard to complete the payment.

[JayWhite2357]

LGTM
Thanks!

[github-actions]

🎉 This PR is included in version 0.22.15 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀