fix: only query finalized blocks in javascript client #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0.4.1Bug Fixes
|
tlovell-sxt
force-pushed
the
fix/js-client-latest-finalized
branch
from
d360eaa to
d351afe
Compare
A difference between the behavior of the rust and javascript clients has been observed which leads to StaleTableData errors in the javascript. When no particular block was requested, the javascript client was simply using the jsonrpc getStorage method without supplying a block. In this case, the jsonrpc uses the latest block, which is not necessarily finalized. On the other hand, the rust was implicitly requesting the latest finalized block via subxt. This change makes it so the javascript is only requesting finalized blocks too, which is important since only events in finalized blocks are inserted to the database.
tlovell-sxt
force-pushed
the
fix/js-client-latest-finalized
branch
from
d351afe to
8222b5c
Compare
JayWhite2357
approved these changes
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
A difference between the behavior of the rust and javascript clients has been observed which leads to StaleTableData errors in the javascript. When no particular block was requested, the javascript client was simply using the jsonrpc getStorage method without supplying a block. In this case, the jsonrpc uses the latest block, which is not necessarily finalized. On the other hand, the rust was implicitly requesting the latest finalized block via subxt. This change makes it so the javascript is only requesting finalized blocks too, which is important since only events in finalized blocks are inserted to the database.
What changes are included in this PR?
Are these changes tested?
No.