Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: authenticate with default github token in release workflows #35

Merged
merged 1 commit into from
Nov 22, 2024
Merged

ci: authenticate with default github token in release workflows #35

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/workflows/preview-release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ jobs:
- name: Checkout
uses: actions/checkout@v4
with:
token: ${{ secrets.GH_TOKEN }}
ref: ${{ github.head_ref }}
# Make sure the value of GITHUB_TOKEN will not be persisted in repo's config
persist-credentials: false
Expand All @@ -29,7 +30,7 @@ jobs:
id: conventional-changelog
uses: TriPSs/conventional-changelog-action@v5
with:
github-token: ${{ steps.app-token.outputs.token }}
github-token: ${{ secrets.GH_TOKEN }}
skip-git-pull: true
skip-version-file: true
git-push: false
Expand Down
26 changes: 5 additions & 21 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,27 +11,11 @@ jobs:
runs-on: ubuntu-latest

steps:
- name: Load Secrets
uses: 1password/load-secrets-action@v1
with:
export-env: true
env:
OP_CONNECT_HOST: ${{ secrets.OP_CONNECT_HOST }}
OP_CONNECT_TOKEN: ${{ secrets.OP_CONNECT_TOKEN }}
GITHUB_APP_ID: op://op-github-devops/cosmic-agent-labs/app-id
GITHUB_PRIVATE_KEY: op://op-github-devops/cosmic-agent-labs/private-key

- name: Create GitHub App Token
id: app-token
uses: actions/create-github-app-token@v1
with:
app-id: ${{ env.GITHUB_APP_ID }}
private-key: ${{ env.GITHUB_PRIVATE_KEY }}

- name: Checkout
uses: actions/checkout@v4
with:
token: ${{ steps.app-token.outputs.token }}
token: ${{ secrets.GH_TOKEN }}
ref: ${{ github.head_ref }}
# Make sure the value of GITHUB_TOKEN will not be persisted in repo's config
persist-credentials: false
Expand All @@ -43,7 +27,7 @@ jobs:
id: conventional-changelog
uses: TriPSs/conventional-changelog-action@v5
with:
github-token: ${{ steps.app-token.outputs.token }}
github-token: ${{ secrets.GH_TOKEN }}
skip-git-pull: true
skip-version-file: true
git-push: false
Expand All @@ -53,13 +37,13 @@ jobs:
uses: ad-m/github-push-action@master
id: push
with:
github_token: ${{ steps.app-token.outputs.token }}
github_token: ${{ secrets.GH_TOKEN }}
branch: ${{ github.ref }}

- name: Create Release
uses: ncipollo/release-action@v1
with:
tag: ${{ steps.conventional-changelog.outputs.tag }}
body: ${{ steps.conventional-changelog.outputs.changelog }}
token: ${{ steps.app-token.outputs.token }}
makeLatest: true
token: ${{ secrets.GH_TOKEN }}
makeLatest: true
Loading