-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DO NOT MERGE] feat: use import to run wasm/client code #33
Conversation
Additionally, some code is refactored to simplify the usage of the SDK Note: there is a build_index.sh script that must be run to build the artifacts needed to import. This script is temporary and should be replace by a CI job that publishes to npm.
This commit is purely from the following command: ``` build_index.sh https://raw.githubusercontent.com/spaceandtimelabs/sxt-proof-of-sql-sdk/refs/heads/feat/wasm-bindgen/crates/proof-of-sql-sdk-wasm/pkg ```
This branch currently fails with:
Is this expected? |
I also noticed the cost of running this example has ballooned in the simulation, although its unlikely this is the real world cost, just worth pointing out:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be committed? The wasm-packed js isn't
0.1.0 (2024-11-22)Bug Fixes
Features
|
a74d5a3
to
f10a02a
Compare
This PR is not ready to merge. The majority of it should never be merged into main. |
cafbb78
to
5c0c7b9
Compare
Rationale for this change
We want to be able to use the SDK more simply from within Chainlink.
What changes are included in this PR?
See the individual commits.
In particular, there is a
build_index.sh
script that prepends the generated js code from wasm-pack to the index_tail.js. None of the generated code needs to change. It can simply be used from within the index_tail.js code.Ultimately, we need to turn this script into a CI job that publishes to npm.
Are these changes tested?
Yes.