Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: uppercase tables and other misc changes #13

Merged
merged 1 commit into from
Oct 23, 2024
Merged

fix: uppercase tables and other misc changes #13

merged 1 commit into from
Oct 23, 2024

Conversation

iajoiner
Copy link
Contributor

@iajoiner iajoiner commented Oct 23, 2024

Rationale for this change

We need to uppercase tables. The other changes are just supposed to make the code base look nicer.

What changes are included in this PR?

  • Uppercase table names for query_commitments.
  • Add AUTH_ROOT_URL and rename PROVER_URL to PROVER_ROOT_URL.
  • Change error handling to make Arrow FlightSQL errors from the prover more obvious..

Are these changes tested?

It compiles.

@iajoiner iajoiner requested a review from Dustin-Ray October 23, 2024 21:02
Copy link
Contributor

@Dustin-Ray Dustin-Ray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iajoiner iajoiner merged commit 173d629 into main Oct 23, 2024
7 checks passed
@iajoiner iajoiner deleted the fix/misc branch October 23, 2024 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants