Experimenting with sharing DirectX textures #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
space928
commented
Oct 25, 2023
space928
commented
- Added HookD3D and CreateTexture methods to OmsiHookInvoker and related RPC classes
- These methods allow Omsi's own d3d context to be used to create new textures and get the shared handle from them to be used by another d3d context for writing
- Added HookD3D and CreateTexture methods to OmsiHookInvoker and related RPC classes - These methods allow Omsi's own d3d context to be used to create new textures and get the shared handle from them to be used by another d3d context for writing
- Fixed build issue with OmsiExtensionsCLI - Handle exceptions in CLI program - Added some demo code to fiddle with D3D textures - Theoretically Memory is now thread safe - Replaced AccessViolationException with custom exception - Added ReadMemoryObject as a factory for OmsiObjects with null checking - ReadMemoryObjArray now does null checking on items - ComplObjInst.ScriptTextures is now a MemArray - OmsiGlobals returns nulls where appropriate - Added experimental events to OmsiHook - Better exceptions for remote methods - Experimental async/multithreading support for RemoteMethods (currently broken)
- Fixed various bugs - Exposed Memory to the public when using debug builds - MemArray refactoring + fixes - Added some overloads to Memory for uint addresses - Memory allocation is now async - Updated classes to support async memory allocation - Rewrote much of OmsiRemoteMethods and the RPC plugin to support async calls - Updated assembly versions - D3D still doesn't work...
- Implemented UpdateSubresource in OmsiHookInvoker, OmsiHookRPC and OmsiHook - Removed shared resource support from create texture, it never would have worked - Other small tweaks
- Fixed example code - Fixed WriteMemory(addr, T[]) buffer overrun - Exposed AllocRemoteMemory() - Added HRESULT enum for easier debugging of OmsiHookInvoker - Added many more sanity checks to DXHook.cpp - Added more bugs
- Dereference the newly created texture pointer correctly - Re-enabled script texture replacement - Added some animation to the texture modification example
- Removed dependency on SharpDX - Updated example program - Implemented new D3DTexture class - Improved memory writing methods to be allocation free - Added FreeRemoteMemory method - OmsiHook now automatically hooks d3d - Added new RPC methods - Fixed UpdateSubresource not copying enough bytes - Improved OmsiHookRPCPlugin logging - Fixed build system a bit, no longer depends on Omsi existing at the assumed path
Closed
amathieson
approved these changes
Nov 20, 2023
| /// <param name="address">the address of the existing texture</param> | ||
| /// <exception cref="NullReferenceException"></exception> | ||
| /// <exception cref="Exception"></exception> | ||
| public async void CreateFromExisting(uint address) |
There was a problem hiding this comment.
Would be good to have a test case for this in the CLI
There was a problem hiding this comment.
Yeah, but we'll leave that on the backlog for now.
| //------------------------------------------------------------------------------------- | ||
| // Returns bits-per-pixel for a given D3D9 format, or 0 on failure | ||
| //------------------------------------------------------------------------------------- | ||
| constexpr size_t DXHook::BitsPerPixel(D3DFORMAT fmt) noexcept |
There was a problem hiding this comment.
is this not a copy of the switch from the other class?
There was a problem hiding this comment.
Yes it mirrors the C# implementation, that is intentional.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.