Omsi Hook RPC Plugin #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oed to external processes using OmsiHook via named pipes. + Created the project file
- Implemented a (slightly) thread safe, multi-client RPCPlugin server - Modified OmsiRemoteMethods to use OmsiHookRPCPlugin if not in an Omsi Plugin - Added GetMem and FreeMem method wrappers - Refactoring
- Memory.AllocateMemory() now uses OmsiGetMem() - OmsiRemotemethods is now static
- Memory reads now use a shared buffer to avoid allocations - Optional fast allocator added (not recommended) - Removed OmsiRemoteMethods from OmsiGlobals (might be temporary) - Bug fixes to OmsiRemoteMethods - Refactoring
- FreeMem now returns the freed address as it should - Renamed OmsiHookRPCPlugin folder - Added support for length prefixed (aka Pascal) strings - Fixed caching bug with MemArrayStringDicts - ReadMemory and WriteMemory now actually check if reads/writes are successful (much spam as a result, but it should encourage us to fix the broken struct definitions) - Added more error checking to array and string reading methods (it seems there are plenty of cases where these try to read invalid data) - Improved debug logging in MarshalStruct to hunt down incorrect marshalling - OmsiRemoteMethods initialisation is now done when you connect to Omsi - Removed some arrays from OmsiComplObjInst which weren't marshalling correctly, to be investigated - Fixed off by 1 error in the argument serialisation/deserialisation of remote method calls - Updated project platform configuration - Fixed many bugs in OmsiHookRPCPlugin & added proper support for multiple clients - Updated OmsiHookRPCPlugin .opl to read the Throttle variable which should always exist - Refactoring
|
Looking great, ill run some tests this evening |
amathieson
approved these changes
Oct 24, 2023
| } | ||
| catch (Exception e) |
There was a problem hiding this comment.
Pedantic but e is never used, throws a warn in the build
There was a problem hiding this comment.
e is used in Debug builds (see the preprocessor block below), but not in Release, I could fix this at the cost of adding another preprocessor block, but who cares...
OmsiHook/OmsiComplObjInst.cs
Outdated
There was a problem hiding this comment.
Looks like you removed some properties, admittedly they where not implemented correctly to startwith
There was a problem hiding this comment.
Yeah we should investigate this, I can't remember if any of these arrays worked correctly before (I know some were broken but I didn't think they all were). Might be a regression.
|
|
||
| [Obsolete] | ||
| public int MakeVehicle() | ||
| public static int MakeVehicle() | ||
| { | ||
| int vehList = TTempRVListCreate(0x0074802C, 1); | ||
| string path = @"Vehicles\GPM_MAN_LionsCity_M\MAN_A47.bus"; |
There was a problem hiding this comment.
I'm guessing this is demo data - probs shouldnt be pushed to prod, maybe bring to an example code or something 🤷
- Added StrPtrType enum to specify how strings are marshalled as an alternative to using the separate boolean flags - OmsiStrArrayPtrAttribute now supports pascal strings - Fixed bug when reading wide pascal strings - Fixed some struct definitions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request isn't ready for merging quite yet and needs some extensive testing. Especially with regards to regression testing as I probably broke a bunch of stuff.