Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

+ OmsiSound Completed for @sjain882 #43

Merged
merged 4 commits into from
May 23, 2022
Merged

+ OmsiSound Completed for @sjain882 #43

merged 4 commits into from
May 23, 2022

Conversation

amathieson
Copy link
Collaborator

  • OmsiBoolClass
  • Required Structs

@amathieson
+ OmsiSound Completed for @sjain882
451fdef 
 + OmsiBoolClass
 + Required Structs
@amathieson amathieson requested a review from space928 May 21, 2022 22:26
space928
space928 requested changes May 23, 2022
View reviewed changes
OmsiHook/OmsiSound.cs Outdated
/// </summary>
public int SoundBuffer
{
get => Memory.ReadMemory<int>(Address + 0xc);
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please cast to an IntPtr

OmsiHook/OmsiSound.cs Outdated
/// </summary>
public int FX_Hall
{
get => Memory.ReadMemory<int>(Address + 0x10);
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please cast to an IntPtr

OmsiHook/OmsiSound.cs Outdated
/// </summary>
public int Int3D
{
get => Memory.ReadMemory<int>(Address + 0x80);
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cast to IntPtr

@amathieson amathieson requested a review from space928 May 23, 2022 12:25
space928
space928 requested changes May 23, 2022
View reviewed changes
OmsiHook/OmsiSound.cs Outdated
/// </summary>
public IntPtr Device
{
get => (IntPtr)Memory.ReadMemory<int>(Address + 0x8);
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

get => new IntPtr(Memory.ReadMemory<int>(Address + 0x8));

@amathieson amathieson requested a review from space928 May 23, 2022 12:28
@amathieson amathieson merged commit e021204 into main May 23, 2022
@amathieson amathieson deleted the OmsiSound branch May 23, 2022 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@space928 space928 space928 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@amathieson @space928