Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File object #25

Merged
merged 7 commits into from
May 5, 2022
Merged

File object #25

merged 7 commits into from
May 5, 2022

Conversation

amathieson
Copy link
Collaborator

No description provided.

amathieson added 3 commits May 4, 2022 00:25
 + Add ChronoVars
 + Finish FileObject (appart from StringVars)
@amathieson amathieson requested a review from space928 May 3, 2022 22:57
Copy link
Owner

@space928 space928 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sometimes I wonder if you read my docs...


internal OmsiChronoChangeLabels(Memory memory, int address) : base(memory, address) { }

/*public string[] StringVars
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You know how to marshall this...

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be corrected now - marshaled correctly

}
/*public string[] StringVars
{
get => Memory.ReadMemoryObjArray<string>(Address + 0x4c);
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Marshall this correctly

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be corrected now - marshalled correcttly

/*
public string[] StringsPnt
{
get => Memory.ReadMemoryObjArray<string>(Memory.ReadMemory<int>(Address + 0xc));
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Marshall this correctly

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be corrected now - marshalled correctly

}
public OmsiFileObjectPathInfo[] Paths
{
get => Memory.ReadMemoryStructArray<OmsiFileObjectPathInfo>(Address + 0x64);
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs extra marshalling

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be corrected now - added extra marshal step

}
public struct OmsiFileObjectPathInfoInternal
{
[OmsiStructArrayPtr(typeof(OmsiPathRule))] public int rules;
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs extra marshalling see the docs for OmsiStructArrayPtr

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be corrected now - added extra marshal step

@amathieson amathieson requested a review from space928 May 4, 2022 22:54
@space928 space928 merged commit 49112a1 into main May 5, 2022
@space928 space928 deleted the FileObject branch May 5, 2022 00:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants