Multiplayer quickstart #107
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
+ AbsPosition_ThreadFree + Start of Multiplayer client & server
…ernions (Compatible with OH2.5.3)
+ Use nuget version of OH in multiplayer
space928
requested changes
Sep 27, 2024
| //vehicle.AbsPosition_Inv = update.abs_position_inv; | ||
| i++; | ||
| } | ||
| else |
| readonly static int MINOR_VERSION = 0; | ||
| public static void ParseMessage(byte[] message, Telepathy.Client client, GameClient gameClient) | ||
| { | ||
| message.AsSpan<byte>(0, message.Length); |
There was a problem hiding this comment.
Why not use this lovely span you just made?
| { | ||
| internal class GameClient | ||
| { | ||
| public Tuple<int, long, long> LastPing; |
There was a problem hiding this comment.
Tuple<int, long, long> LastPing --> (int xxx, long yyy, long zzz) lastPing
| default: | ||
| { | ||
| Console.WriteLine($"Data received {message}"); | ||
| break; |
There was a problem hiding this comment.
Please be consistent with where you put your break statements.
| while (true) | ||
| { | ||
| Telepathy.Message msg; | ||
| while (client.GetNextMessage(out msg)) |
There was a problem hiding this comment.
Just realised that the version of Telepathy on NuGet is really out of date (from 2019)...
Latest build is here: https://github.com/MirrorNetworking/Telepathy/actions/runs/10029006044
Anyway, is this a blocking method? If so, why do you thread sleep at the end of this method?
| { | ||
| case OMSIMPMessages.Messages.REQUEST_VERSION: | ||
| { | ||
| byte[] buff = new byte[12]; |
There was a problem hiding this comment.
Again, this is an avoidable allocation...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.