Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates for string support and version increases on demos #106

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Updates for string support and version increases on demos #106

wants to merge 5 commits into from

Conversation

amathieson
Copy link
Collaborator

  • Support for Reading and Writing OSC strings + Bump versions on all the demos
  • Bump versions on all the demos

@amathieson
+ Support for Reading and Writing OSC strings
806b851 
 + Bump versions on all the demos
@amathieson amathieson requested a review from space928 September 27, 2024 11:32
space928
space928 reviewed Sep 27, 2024
View reviewed changes
Copy link
Owner

@space928 space928 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but we need to increment the version number before merging.

@amathieson amathieson requested a review from space928 September 27, 2024 14:14
space928
space928 reviewed Sep 27, 2024
View reviewed changes
Copy link
Owner

@space928 space928 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't forget to update the version in DocFX.

_OmsiHookExamples/BasicCLI/BasicCLI.csproj Outdated Show resolved Hide resolved
@amathieson amathieson requested a review from space928 September 30, 2024 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@space928 space928 Awaiting requested review from space928

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@amathieson @space928