arrayCache.Length NullReferenceException

[lmoadeck-Lunity]

System.NullReferenceException
HResult=0x80004003
Message=Object reference not set to an instance of an object.
Source=OmsiHook
StackTrace:
at OmsiHook.MemArrayBase`1.get_Count() in D:\users\suityan\Source\Repos\Omsi-Extensions2\OmsiHook\MemArrayBase.cs:line 26
do not know sure why it happens

[lmoadeck-Lunity]

ok so it is confirmed that it crashed after i spawned my bus

[lmoadeck-Lunity]

i used the CLI project

[space928]

This can happen if a MemArray is created but not properly initialised. To construct a MemArray you must either use the two-parameter constructor (eg: new MemArray(memory, address)) or use the zero-parameter constructor and then call InitObject before you use it (eg: var ma = new MemArray(); ma.InitObject(memory, address)). If you're not constructing the MemArray yourself, then this could be a bug with one of our wrapper classes, in which case I would need the full stack trace to see where it went wrong.

…

On Thu, 30 Nov 2023 at 14:32, Ed ***@***.***> wrote: i used the CLI project — Reply to this email directly, view it on GitHub <#76 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ADTN4AWPKBSLCYKGFYPJFLTYHCKIHAVCNFSM6AAAAABABIP3KWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMZTHA4TCMRUGY> . You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

-- Thomas

[lmoadeck-Lunity]

i used the original CLI and did not change anything.
stack trace:

Unhandled exception. System.NullReferenceException: Object reference not set to an instance of an object.
   at OmsiHook.MemArrayBase`1.get_Count() in D:\users\suityan\Source\Repos\Omsi-Extensions2\OmsiHook\MemArrayBase.cs:line 26
   at OmsiExtensionsCLI.DXTests.CreateTexture() in D:\users\suityan\Source\Repos\Omsi-Extensions2\OmsiExtensionsCLI\Program.cs:line 104
   at OmsiExtensionsCLI.Program.Main(String[] args) in D:\users\suityan\Source\Repos\Omsi-Extensions2\OmsiExtensionsCLI\Program.cs:line 45

D:\users\suityan\Source\Repos\Omsi-Extensions2\OmsiExtensionsCLI\bin\Debug\net6.0-windows\OmsiExtensionsCLI.exe (process 27948) exited with code 0

[space928]

Ah, ok I see what the problem is. It seems that the vehicle's script texture array is null in Omsi, which means OmsiHook can't dereference it. In the future I might make it so that MemArrays handle this behaviour a bit better. For now though, if you need to use access script textures (to use the example in OmsiExtensionsCLI) you can either: make sure your bus has script textures, or wrap the MemArray access in a try catch block, or test if the scriptTexes.WrappedArray property is null before accessing scriptTexes.Count.

So for instance in the CreateTexture() method of Program.cs, change it to include this:

// [...]

var scriptTexes = omsi.Globals.PlayerVehicle.ComplObjInst.ScriptTextures;
//+++++++++++ BEGIN
if (scriptTexes.WrappedArray == null)
    return;  // The player vehicle has no script textures to replace
//+++++++++++ END
for (int i = 0; i < scriptTexes.Count; i++)
{
    var old = scriptTexes[i];
    Console.WriteLine($"Replacing script tex: texPn:uint[{old.TexPn?.Length??-1}], color:{old.color}, tex:{old.tex} with tex:{texture.TextureAddress}");
    scriptTexes[i] = new()
    {
        TexPn = old.TexPn,
        color = old.color,
        tex = unchecked((IntPtr)texture.TextureAddress)
    };
}