Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Storage CanInsert() tweaks #21623

Merged
merged 3 commits into from
Nov 13, 2023
Merged

Storage CanInsert() tweaks #21623

merged 3 commits into from
Nov 13, 2023

Conversation

ElectroJr
Copy link
Member

This PR changes how storage does the can-insert checks so that it uses the container system insert attempt events. This should prevent the size/storage limits from being exceeded by direct insertions (e.g., see https://discord.com/channels/310555209753690112/560845886263918612/1173334861910659072).

This also fixes some other miscellaneous bugs:

  • If a stack of items is only partially inserted, it no longer drops the item and no longer creates a failure pop-up.
  • Changing item stack counts sometimes didn't update the storage UI & appearance data.
Content.Client_E3RVnewXkn.mp4

@github-actions github-actions bot added the S: Needs Review Status: Requires additional reviews before being fully accepted label Nov 12, 2023
@metalgearsloth metalgearsloth merged commit eb0c86f into space-wizards:master Nov 13, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Emisse Emisse Emisse approved these changes

@EmoGarbage404 EmoGarbage404 Awaiting requested review from EmoGarbage404 EmoGarbage404 is a code owner

Assignees
No one assigned
Labels
S: Needs Review Status: Requires additional reviews before being fully accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ElectroJr @Emisse @metalgearsloth