Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added global emote CVars #5509

Closed

Conversation

Nettingman
Copy link

Added CVar settings for user defined custom emotes.
Requirement of other PR.

@PJB3005
Copy link
Member

PJB3005 commented Nov 3, 2024

Why is this in its own PR?

@Nettingman
Copy link
Author

Isn't it how I should submit them?
PRs with engine changes page says it should be submitted first and then referenced in the main PR:
https://docs.spacestation14.com/en/general-development/tips/prs-with-engine-changes.html

Sorry this is my first PR with engine change, I may have misunderstood something.

@PJB3005
Copy link
Member

PJB3005 commented Nov 3, 2024

I didn't realize this is in Robust, which begs the next question: why is this in Robust?

@Nettingman
Copy link
Author

Because it's a new CVar. I was following the pattern of other user settings which all had their own CVars.

@PJB3005
Copy link
Member

PJB3005 commented Nov 3, 2024

You can define the new CVars in content with CCVars.cs.

@Nettingman
Copy link
Author

Oh damn, I see. Thank you. This can be closed then.

@PJB3005 PJB3005 closed this Nov 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants