-
-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Matrix builds for tests #29
Conversation
Thanks @AlexNDRmac for this PR, your contribution was really helpful. Given that I'm not a macOS user, it's a bit tricky to test it on my own. The necessary packages are mentioned in the readme file and also, and the packages are installed using the kickstart script Regarding the bug, the check you proposed is exactly the same as this one. Did I miss something? |
I missed your kickstarter script :) it solves question with dependencies. if [ "$(command -v ggper 2>/dev/null)" = "" ]; then
(>&1 echo "Required tool 'ggrep' not found...")
(>&1 echo "Install it with 'brew install grep'")
exit 1
fi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Hi @sp1thas
Added:
Changed:
paths-ignore
intesting.yml
to avoid run build when it does not make senseactions/checkout@v2
toactions/checkout@v3
because old version has deprecated node12Closes #28
Notes:
macOS tests will fail if you does't have GNU diff and GNU grep (
diffutils
andgrep
in brew) in your system.Also, I found possible bug in
dropboxignore.sh
which I would recommend to resolve with additional check:If you does't have
ggrep
anddiff
in brew path – you'll see error which is not related to dropbox ignore features, it's error with third party software which you use inside script. It'll be more explicit if you'll check these tools before usage. With macOS defaultgrep
- tests also fails with error/usr/local/bin/diff: unrecognized option
--ignore-trailing-space'`For macOS users - I would recommend you to add all these prerequisites to Readme or other documentation.