Merge pull request kubernetes-sigs#524 from kubernetes-sigs/lock-issue

fix: account creation lock issue
sozercan · Jan 11, 2021 · 3b2295f · 3b2295f
2 parents 0474e87 + bc99fa0
commit 3b2295f
Showing 1 changed file with 1 addition and 2 deletions.
diff --git a/pkg/azurefile/controllerserver.go b/pkg/azurefile/controllerserver.go
@@ -210,8 +210,6 @@ func (d *Driver) CreateVolume(ctx context.Context, req *csi.CreateVolumeRequest)
 	if len(req.GetSecrets()) == 0 && accountName == "" {
 		lockKey := sku + accountKind + resourceGroup + location
 		d.volLockMap.LockEntry(lockKey)
-		defer d.volLockMap.UnlockEntry(lockKey)
-
 		err = wait.ExponentialBackoff(d.cloud.RequestBackoff(), func() (bool, error) {
 			var retErr error
 			accountName, accountKey, retErr = d.cloud.EnsureStorageAccount(accountOptions, fileShareAccountNamePrefix)
@@ -221,6 +219,7 @@ func (d *Driver) CreateVolume(ctx context.Context, req *csi.CreateVolumeRequest)
 			}
 			return true, retErr
 		})
+		d.volLockMap.UnlockEntry(lockKey)
 		if err != nil {
 			return nil, status.Errorf(codes.Internal, "failed to ensure storage account: %v", err)
 		}