ST-618: use correct parent class for Authenticators #288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ashcherbakov <[email protected]>
Signed-off-by: ashcherbakov <[email protected]>
skhoroshavin
approved these changes
Aug 1, 2019
| looper.run(eventually( | ||
| lambda: assertExp( | ||
| get_committed_txns_count_for_pool(nodeSetWithIntegratedTokenPlugin, | ||
| TOKEN_LEDGER_ID) == committed_size_before_token + 1 |
There was a problem hiding this comment.
Some time ago when debugging tests which used assertExp I found that pytest doesn't output any useful information except that assert failed. For that reason I've created another helper called assert_eq which accepts two parameters (left-hand and right-hand side) and in case of assertion failure outputs their values, which often can lead to faster problem detection. So, I recommend using this helper here as well.
KitHat
approved these changes
Aug 1, 2019
lampkin-diet
pushed a commit
to lampkin-diet/token-plugin
that referenced
this pull request
Aug 29, 2019
ST-618: use correct parent class for Authenticators Signed-off-by: Andrew Nikitin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TokenAuthNrandFeesAuthNrextend LedgerBasedAuthNr, not CoreAuthNr now