[INDY-2154] Cleanup after req handlers integration #276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
July 4, 2019 09:02
Signed-off-by: Andrew Nikitin <[email protected]>
Signed-off-by: Andrew Nikitin <[email protected]>
Signed-off-by: Andrew Nikitin <[email protected]>
Signed-off-by: Andrew Nikitin <[email protected]>
Signed-off-by: Andrew Nikitin <[email protected]>
…n into public/indy-2154 Signed-off-by: Andrew Nikitin <[email protected]>
Signed-off-by: Andrew Nikitin <[email protected]>
Signed-off-by: Andrew Nikitin <[email protected]>
lampkin-diet
changed the title
skhoroshavin
previously approved these changes
Jul 7, 2019
Signed-off-by: Andrew Nikitin <[email protected]>
skhoroshavin
previously approved these changes
Jul 8, 2019
ashcherbakov
reviewed
Jul 8, 2019
| @@ -48,7 +49,7 @@ def test_state_proof(public_minting, looper, # noqa | |||
| encoded = {} | |||
| outputs = res[OUTPUTS] | |||
| for out in outputs: | |||
| state_key = TokenReqHandler.create_state_key(out["address"], out["seqNo"]) | |||
| state_key = create_state_key(out["address"], out["seqNo"]) | |||
There was a problem hiding this comment.
Should we use a method from GetUtxoHandler?
| node.write_manager.register_batch_handler(h) | ||
| # TODO: Additional functionality to request_manager ^^^ | ||
|
|
||
| domain_fee_batch_handler = DomainFeeBatchHandler(node.db_manager, fees_tracker) |
There was a problem hiding this comment.
It looks like we need to put it before Audit Handler since Audit ledger tracks ledger root hashes and sizes for all ledger (two ledgers are changed if we order a domain txn with fees)
KitHat
previously requested changes
Jul 8, 2019
| @@ -34,6 +34,10 @@ def static_validation(self, request: Request): | |||
| request.reqId, | |||
| error) | |||
|
|
|||
| @staticmethod | |||
| def create_state_key(address: str, seq_no: int) -> bytes: | |||
There was a problem hiding this comment.
We need some consistency here.
We have already defined this method in https://github.com/sovrin-foundation/token-plugin/blob/master/sovtoken/sovtoken/request_handlers/token_utils.py#L30
We should either use the one in token_utils.py either delete it and use only the one here.
By the way, this is a utility method and don't see any reason to keep it in this class.
added 3 commits
July 8, 2019 15:22
Signed-off-by: Andrew Nikitin <[email protected]>
…n into public/indy-2154
added 4 commits
July 9, 2019 10:09
Signed-off-by: Andrew Nikitin <[email protected]>
Signed-off-by: Andrew Nikitin <[email protected]>
Signed-off-by: Andrew Nikitin <[email protected]>
Signed-off-by: Andrew Nikitin <[email protected]>
ashcherbakov
approved these changes
Jul 9, 2019
skhoroshavin
approved these changes
Jul 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.