Build pool fixes #136
Merged
Build pool fixes #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Cam Parra <[email protected]>
Signed-off-by: Cam Parra <[email protected]>
brentzundel
reviewed
Aug 30, 2018
| @@ -56,8 +56,8 @@ ARG python3_indy_crypto_ver=0.4.1 | |||
| ARG indy_crypto_ver=0.4.0 | |||
| ARG indy_plenum_ver=1.6.50 | |||
|
|
|||
There was a problem hiding this comment.
I feel there should be a comment here to explain that these values are dynamically supplied by the prep script.
There was a problem hiding this comment.
by this I mean sovtoken_pkg_name and sovtokenfee_pkg_name
There was a problem hiding this comment.
I removed the names since they should always be supplied by the prep script
There was a problem hiding this comment.
exactly, which is why a comment to that effect would be really helpful, otherwise someone trying to debug might be confused.
|
This will help with debugging errors, thanks! |
brentzundel
approved these changes
Aug 31, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The file is now not a demo tool and more of a dev tool