Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

config as java code #1051

Merged
merged 21 commits into from
Oct 2, 2024
Merged

config as java code #1051

merged 21 commits into from
Oct 2, 2024

Conversation

richardtreier
Copy link
Collaborator

@richardtreier richardtreier commented Oct 1, 2024 •
edited
Loading

closes https://github.com/sovity/PMO-Software/issues/568

  • central config validation and defaulting for all environments (ci, prod, local demo docker compose) in java code
    • removed .env files that were sourced as bash in production
  • preparation for documentation generation for available configuration

@richardtreier richardtreier changed the title 2024 09 26 config as java code config as java code Oct 1, 2024
ununhexium
ununhexium requested changes Oct 1, 2024
View reviewed changes
Copy link
Collaborator

@ununhexium ununhexium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Globally happy with the direction that this is taking.

I think that you broke the testEnvAndJar() test and maybe other with the change in default values.

config/src/main/java/de/sovity/edc/utils/config/utils/UrlPathUtils.java Show resolved Hide resolved
config/src/test/java/UrlPathUtilsTest.java Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
config/src/main/java/de/sovity/edc/utils/config/ConfigProps.java Outdated Show resolved Hide resolved
config/src/main/java/de/sovity/edc/utils/config/ConfigProps.java Outdated Show resolved Hide resolved
.../wrapper/wrapper/src/main/java/de/sovity/edc/ext/wrapper/WrapperExtensionContextBuilder.java Outdated Show resolved Hide resolved
...rc/main/java/de/sovity/edc/ext/wrapper/api/ui/pages/dashboard/services/MiwConfigService.java Show resolved Hide resolved
.../test/java/de/sovity/edc/ext/wrapper/api/ui/pages/dashboard/DashboardPageApiServiceTest.java Show resolved Hide resolved
launchers/connectors/mds-ce/build.gradle.kts Show resolved Hide resolved
...utils/src/main/java/de/sovity/edc/extension/e2e/connector/config/ConnectorConfigFactory.java Show resolved Hide resolved
ununhexium
ununhexium previously approved these changes Oct 2, 2024
View reviewed changes
Copy link
Collaborator

@ununhexium ununhexium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@richardtreier richardtreier enabled auto-merge (squash) October 2, 2024 10:04
ununhexium
ununhexium approved these changes Oct 2, 2024
View reviewed changes
Copy link
Collaborator

@ununhexium ununhexium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@richardtreier richardtreier merged commit a485964 into main Oct 2, 2024
18 checks passed
@richardtreier richardtreier deleted the 2024-09-26-config-as-java-code branch October 2, 2024 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ununhexium ununhexium ununhexium approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@richardtreier @ununhexium