Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Asset Properties need to be persisted on the consumer side #427

Open
8 tasks
richardtreier opened this issue Jul 13, 2023 · 1 comment
Open
8 tasks

Asset Properties need to be persisted on the consumer side #427

richardtreier opened this issue Jul 13, 2023 · 1 comment
Assignees
Labels
kind/bug Something isn't working. The software does not behave as expected or specified. kind/enhancement New feature or request scope/ce sovity's Open Source Community Edition scope/ee-basic Basic subscription tier is impacted. scope/ee-professional Professional subscription tier is impacted. scope/mds related to MDS

Comments

@richardtreier
Copy link
Collaborator

richardtreier commented Jul 13, 2023

Feature Request

Description

Right now we cant show asset properties for consuming contract agreements or transfer processes.

This is bad, because our parameterization hints can't be shown, the endpoint documentation can't be shown, etc., which is all very annoying.

The Core EDC has said this is not a bug to them, as they expect connectors to crawl periodically all connectors of the data space which we consider harmful (n²).

Solution Proposal and Work Breakdown

  • Check if in edc 0.1.x the contract negotiation table contains the asset or not.
  • If not:
    • Add JooQ to edc-extensions
    • Add a custom table to persist foreign assets, I recommend JSONB for the asset properties. And also add a "lastRefreshedAt".
    • These foreign assets need to be keyed by the connector endpoint + the asset id
  • Add a custom API wrapper endpoint that starts a contract negotiation. That one also contains the asset properties. Unless an EDC Event will actually re-fetch the asset. Assets cannot be fetched as such, as only contract offers can be fetched. These might be restricted by n-times usage or other similar things. So we persist the "last known asset properties" when initiating a negotiation.
  • The transfer endpoint and contract agreement endpoints should show these asset properties for consuming contracts.
  • Update the UI to use the new negotiation endpoint.
@richardtreier richardtreier added the kind/enhancement New feature or request label Jul 13, 2023
@richardtreier richardtreier added scope/ce sovity's Open Source Community Edition scope/mds related to MDS scope/ee-basic Basic subscription tier is impacted. scope/ee-professional Professional subscription tier is impacted. priority/backlog labels Jul 13, 2023
@richardtreier richardtreier added the kind/bug Something isn't working. The software does not behave as expected or specified. label Aug 10, 2023
@bearn01d
Copy link

@richardtreier Is there a rough timeline for this issue to be addressed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working. The software does not behave as expected or specified. kind/enhancement New feature or request scope/ce sovity's Open Source Community Edition scope/ee-basic Basic subscription tier is impacted. scope/ee-professional Professional subscription tier is impacted. scope/mds related to MDS
Projects
None yet
Development

No branches or pull requests

7 participants